CODEWITHSUNDEEP
c#regex
Game_Overture
Game_Overture

Reputation: 1666

Regular expressions in C# for file name validation

What is a good regular expression that can validate a text string to make sure it is a valid Windows filename? (AKA not have \/:*?"<>| characters).

I'd like to use it like the following:

// Return true if string is invalid.
if (Regex.IsMatch(szFileName, "<your regex string>"))
{
    // Tell user to reformat their filename.
}

Upvotes: 19

Views: 37791

Answers (4)

Viacheslav Ivanov
Viacheslav Ivanov

Reputation: 1555

Path.GetInvalidFileNameChars - Is not a good way. Try this:

if(@"C:\A.txt".IndexOfAny(System.IO.Path.GetInvalidFileNameChars()) != -1)
{
  MessageBox.Show("The filename is invalid");
  return;
}

Upvotes: 0

Greg Beech
Greg Beech

Reputation: 136637

This isn't as simple as just checking whether the file name contains any of System.IO.Path.GetInvalidFileNameChars (as mentioned in a couple of other answers already).

For example what if somebody enters a name that contains no invalid chars but is 300 characters long (i.e. greater than MAX_PATH) - this won't work with any of the .NET file APIs, and only has limited support in the rest of windows using the \?\ path syntax. You need context as to how long the rest of the path is to determine how long the file name can be. You can find more information about this type of thing here.

Ultimately all your checks can reliably do is prove that a file name is not valid, or give you a reasonable estimate as to whether it is valid. It's virtually impossible to prove that the file name is valid without actually trying to use it. (And even then you have issues like what if it already exists? It may be a valid file name, but is it valid in your scenario to have a duplicate name?)

Upvotes: 6

Isak Savo
Isak Savo

Reputation: 35884

As answered already, GetInvalidFileNameChars should do it for you, and you don't even need the overhead of regular expressions:

if (proposedFilename.IndexOfAny(System.IO.Path.GetInvalidFileNameChars()) != -1)
{
  MessageBox.Show("The filename is invalid");
  return;
}

Upvotes: 50

Drejc
Drejc

Reputation: 14286

Why not using the System.IO.FileInfo class, together with the DirectoryInfo class you have a set of usefull methods.

Upvotes: 0

Related Questions