Reputation: 14460
Say I have a list x
with unkown length from which I want to randomly pop one element so that the list does not contain the element afterwards. What is the most pythonic way to do this?
I can do it using a rather unhandy combincation of pop
, random.randint
, and len
, and would like to see shorter or nicer solutions:
import random
x = [1,2,3,4,5,6]
x.pop(random.randint(0,len(x)-1))
What I am trying to achieve is consecutively pop random elements from a list. (i.e., randomly pop one element and move it to a dictionary, randomly pop another element and move it to another dictionary, ...)
Note that I am using Python 2.6 and did not find any solutions via the search function.
Upvotes: 121
Views: 128557
Reputation: 2684
despite many answers suggesting use random.shuffle(x)
and x.pop()
its very slow on large data. and time required on a list of 10000
elements took about 6 seconds
when shuffle is enabled. when shuffle is disabled speed was 0.2s
the fastest
method after testing all the given methods above was turned out to be written by @jfs because only one item is touched.
import random
L = [1,"2",[3],(4),{5:"6"},'etc'] #you can take mixed or pure list
i = random.randrange(len(L)) # get random index
L[i], L[-1] = L[-1], L[i] # swap with the last element
x = L.pop() # pop last element O(1)
alternatively enhancing (niklas answer), doing random.shuffle() over all elements (costly) which can be one-linered as:
random.shuffle((L := ["a","b",...,"z"])) # enjoy 🦭 walrus operator available in 3.10 :)
for el in L:
print(el)
jfs answer
"lazily" randomizes only 1 sample, and can be used with for loop. the benefit over The implementation of niklas answer
random.shuffle() which uses the Fisher-Yates shuffle algorithm is that, it does not iterate all O(n). you are encouraged to use a generator and wrap it over to only pay for what you use
, in other words, shuffle swaps n
times.
in support of my claim regarding speed concerns for popping from middle, here is the time complexity chart from official source
you can achieve your purpose using sets too. once list made into set duplicates will be removed. remove by value
and remove random
cost O(1)
, ie very effecient. this is the cleanest method i could come up with.
L=set([1,2,3,4,5,6...]) #directly input the list to inbuilt function set()
while 1:
r=L.pop()
#do something with r , r is random element of initial list L.
Unlike lists
which support A+B
option, sets
also support A-B (A minus B)
along with A+B (A union B)
and A.intersection(B,C,D)
. super useful when you want to perform logical operations on the data.
IF you want speed when operations performed on head and tail of list, use python dequeue (double ended queue) in support of my claim here is the image. an image is thousand words.
Upvotes: 15
Reputation: 2170
I know this is an old question, but just for documentation's sake:
If you (the person googling the same question) are doing what I think you are doing, which is selecting k number of items randomly from a list (where k<=len(yourlist)), but making sure each item is never selected more than one time (=sampling without replacement), you could use random.sample like @j-f-sebastian suggests. But without knowing more about the use case, I don't know if this is what you need.
Upvotes: 5
Reputation: 95348
What you seem to be up to doesn't look very Pythonic in the first place. You shouldn't remove stuff from the middle of a list, because lists are implemented as arrays in all Python implementations I know of, so this is an O(n)
operation.
If you really need this functionality as part of an algorithm, you should check out a data structure like the blist
that supports efficient deletion from the middle.
In pure Python, what you can do if you don't need access to the remaining elements is just shuffle the list first and then iterate over it:
lst = [1,2,3]
random.shuffle(lst)
for x in lst:
# ...
If you really need the remainder (which is a bit of a code smell, IMHO), at least you can pop()
from the end of the list now (which is fast!):
while lst:
x = lst.pop()
# do something with the element
In general, you can often express your programs more elegantly if you use a more functional style, instead of mutating state (like you do with the list).
Upvotes: 135
Reputation: 2584
This answer comes courtesy of @niklas-b:
"You probably want to use something like pypi.python.org/pypi/blist "
To quote the PYPI page:
...a list-like type with better asymptotic performance and similar performance on small lists
The blist is a drop-in replacement for the Python list that provides better performance when modifying large lists. The blist package also provides sortedlist, sortedset, weaksortedlist, weaksortedset, sorteddict, and btuple types.
One would assume lowered performance on the random access/random run end, as it is a "copy on write" data structure. This violates many use case assumptions on Python lists, so use it with care.
HOWEVER, if your main use case is to do something weird and unnatural with a list (as in the forced example given by @OP, or my Python 2.6 FIFO queue-with-pass-over issue), then this will fit the bill nicely.
Upvotes: 1
Reputation: 14292
While not popping from the list, I encountered this question on Google while trying to get X random items from a list without duplicates. Here's what I eventually used:
items = [1, 2, 3, 4, 5]
items_needed = 2
from random import shuffle
shuffle(items)
for item in items[:items_needed]:
print(item)
This may be slightly inefficient as you're shuffling an entire list but only using a small portion of it, but I'm not an optimisation expert so I could be wrong.
Upvotes: 2
Reputation: 414745
To remove a single element at random index from a list if the order of the rest of list elements doesn't matter:
import random
L = [1,2,3,4,5,6]
i = random.randrange(len(L)) # get random index
L[i], L[-1] = L[-1], L[i] # swap with the last element
x = L.pop() # pop last element O(1)
The swap is used to avoid O(n) behavior on deletion from a middle of a list.
Upvotes: 23
Reputation: 236112
Here's another alternative: why don't you shuffle the list first, and then start popping elements of it until no more elements remain? like this:
import random
x = [1,2,3,4,5,6]
random.shuffle(x)
while x:
p = x.pop()
# do your stuff with p
Upvotes: 10
Reputation: 208635
You won't get much better than that, but here is a slight improvement:
x.pop(random.randrange(len(x)))
Documentation on random.randrange()
:
random.randrange([start], stop[, step])
Return a randomly selected element fromrange(start, stop, step)
. This is equivalent tochoice(range(start, stop, step))
, but doesn’t actually build a range object.
Upvotes: 69