CODEWITHSUNDEEP
iosmemory-managementmemory-leaks
Voloda2
Voloda2

Reputation: 12607

I have some leaks in init. I see no one leak

I'm using leaks tool of instruments. It says that I have some leaks in the init method. It shows that NSMutableArray has leak.

I don't see any leaks.

@interface BookSettings : NSObject
  @property (nonatomic, retain) NSString *title;
  @property (nonatomic, retain) NSMutableArray *authors;
@end

- (id)init 
{
   self = [super init];

   if(self) 
   {
    title           = [[NSString stringWithString:@""] retain];
    authors         = [[NSMutableArray alloc] init];
   }
   return self;
}

- (void)dealloc 
{
 [title release];
 [authors release];
 [super dealloc];
}

Upvotes: 0

Views: 161

Answers (2)

zaph
zaph

Reputation: 112855

The provided code is OK, the problem is somewhere else where authors is retained without a balancing release. Leaks just points to the place ivar is created, not where the missing release should be. Check all the places where the retain count is increased.

If you need to see where retains, releases and autoreleases occur for an object use instruments:

Run in instruments, in Allocations set "Record reference counts" on on (you have to stop recording to set the option). Cause the problem code to run, stop recording, search for there ivar of interest, drill down and you will be able to see where all retains, releases and autoreleases occurred.

Seriously consider using ARC, there is little reason not to, ARC supports back to iOS 4.x.

BTW:

title = [[NSString stringWithString:@""] retain];

can be more compactly written:

title= @"";

Upvotes: 2

BBog
BBog

Reputation: 3650

I think it's from title. You already have that property nonatomic, retain, so it this means a retain count of 1.

Then you specify another retain, making the retain count 2.

In the dealloc, you release it once, decreasing the retain count to 1. So this 1 reference that keeps retaining the string is the leak.

I don't understand why you are initialising the string like that anyway...

Upvotes: 0

Related Questions