CODEWITHSUNDEEP
iphoneobjective-cuitableviewios5
B25Dec
B25Dec

Reputation: 2377

tableview is crashing on clicking on cell or on scrolling in ios 5

I made a demo empty app and add a navigation controller with the view 

UINavigationController *navBar = [[UINavigationController alloc]initWithRootViewController:objFirstViewControllerViewController];
[self.window addSubview:navBar.view];

After it i add a table view on the first view controller like this .

UITableView* demotableView = [[UITableView alloc]initWithFrame:CGRectMake(0, 0, 320, 400) style:UITableViewStylePlain];
demotableView.delegate = self;
demotableView.dataSource = self;
[self.view addSubview:demotableView];

and the delegate function of the table view and main cell for row function like this way 

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {
 NSString *CellIdentifier = @"Cell";

UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];
cell = [[UITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:CellIdentifier];
  cell.textLabel.text = @"Hello this is sample text";
cell.textLabel.minimumFontSize = 12;
cell.textLabel.adjustsFontSizeToFitWidth = TRUE;
cell.textLabel.font = [UIFont fontWithName:@"Copperplate" size:18];
return cell;
}

But when i scroll on my table or click any cell to go on the next view it just crash and give these two error on clicking and scrolling respectively.

[__NSCFArray tableView:didSelectRowAtIndexPath:]
[__NSCFDictionary tableView:cellForRowAtIndexPath:]

I don't understand what is getting wrong this code it have been working with the prior os properly

Any body can help please ?

Here is the code for did select row

- (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath {
Second *anotherViewController = [[Second alloc] initWithNibName:nil bundle:nil];
[self.navigationController pushViewController:anotherViewController animated:YES];

}

and no of row is this one 

- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section {

return 15;
}

Upvotes: 0

Views: 1164

Answers (4)

B25Dec
B25Dec

Reputation: 2377

Actually I misused the ARC what are the changes I made to make the app run successfully actually it was crashing due to memory leak I reference the class in delegate with local object but the it got released when it tried to add the data on it and when table's delegate and datasource try to add the things in the current class it was released and it throw message from those message instances, I was stuck because I was thinking it is happening due to me having taken an empty kind of application but after adding the lines below in the delegate class I got the problem solved.

What I did in the delegate class in the .h file:

 FirstViewControllerViewController *objFirstViewControllerViewController;

@property (strong, nonatomic)  FirstViewControllerViewController *objFirstViewControllerViewController;

Then my table started behaving properly and all things that I was having problem in.

Upvotes: 1

chandu
chandu

Reputation: 476

Since you have set demotableView.delegate = self; you have to implement the tabelView: didSelectRowAtIndexPath: function which solves the crash on selecting(on Click) a Cell.

To resolve the crash of scrolling, you hav to implement 

- (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section;

method.

P.S: In the cellForRowAtIndexPath:, all the lines except cell.textLabel.text should be inside

if(cell == nil){
}

and please follow proper maemory management rules

Upvotes: 0

Anshul Jain
Anshul Jain

Reputation: 901

Please try this....

add your table view like this..

 productList = [[UITableView alloc] initWithFrame:CGRectMake(0,102, 320, 267) style:UITableViewStylePlain];
 productList.delegate = self;
 productList.dataSource = self;
 productList.backgroundColor = [UIColor clearColor];
 [self.view addSubview:productList];

and add these methods....

  #pragma mark Table view data source

  // Customize the number of sections in the table view.
    - (NSInteger)numberOfSectionsInTableView:(UITableView *)tableView {
      return 1;
   }


 // Customize the number of rows in the table view.
   - (NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section {
     return (your row count);
    }


 // Customize the appearance of table view cells.
  - (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath {

    static NSString *CellIdentifier = @"Cell";

    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];
    if (cell == nil) {
         cell = [[[UITableViewCell alloc] initWithStyle:UITableViewCellStyleSubtitle reuseIdentifier:CellIdentifier]autorelease];
     }

 // Configure the cell.

         cell.textLabel.text = @"Title";
         cell.detailTextLabel.text = formattedString;
         cell.detailTextLabel.textColor = [UIColor darkGrayColor];

         return cell;

      }

  - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath {
      Second *anotherViewController = [[Second alloc] initWithNibName:nil bundle:nil];
     [self.navigationController pushViewController:anotherViewController animated:YES];

   }

Upvotes: 0

Aadil Khan
Aadil Khan

Reputation: 39

Replace your code by this and try:

- (UITableViewCell *)tableView:(UITableView *)tableView cellForRowAtIndexPath:(NSIndexPath *)indexPath 
{
  static NSString *CellIdentifier = @"Cell";

  UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:CellIdentifier];
  if(cell == nil)
  {
    cell = [[UITableViewCell alloc] initWithStyle:UITableViewCellStyleDefault reuseIdentifier:CellIdentifier];

  }
  cell.textLabel.text = @"Hello this is sample text";

  cell.textLabel.minimumFontSize = 12;

  cell.textLabel.adjustsFontSizeToFitWidth = TRUE;

  cell.textLabel.font = [UIFont fontWithName:@"Copperplate" size:18];

  return cell;
}

Hope this helps.

Upvotes: 0

Related Questions