CODEWITHSUNDEEP
c#exceptiontask-parallel-library
Fore
Fore

Reputation: 6146

Task Parallel Library and exception

I have an application that are executing 4 different jobs parallel. I use the parallel task library.

The code looks like this:

while (true)
        {
            var fetch = new FetcherHandler();

            var tasks = new Task[4];

            tasks[0] = Task.Factory.StartNew(fetch.GetJobs);

            tasks[1] = Task.Factory.StartNew(fetch.GetStatusNew);

            tasks[2] = Task.Factory.StartNew(fetch.GetJobsForStatus);

            tasks[3] = Task.Factory.StartNew(fetch.GetStatusOld);
            Task.WaitAll(tasks);

            Thread.Sleep(10000);
        }

The thread.Sleep above will never be reached since all these 4 tasks is in a never ending loop. Code example for the first task: 

public void GetJobs()
        {
    while (true)
            {
                try
                    {
                        handler.GetNewJob();
                        }
                    catch (Exception exception)
                    {
                            var mail = new MailService();
                            mail.SendExeption("Error has accured in GetJobs", exception);
                            throw;
                        }
                    }
                }
                Thread.Sleep(15000); }}

The above code works great, it does some jobs and then it sleeps for 15 sec, and then it does it again. The problem occurres when I get an exception.

The exception is caught alright, and sends me an mail, but the thred doesn't continue in the loop after the exception, so the GetNewJob() method will never get executed again.

Any ideas what happens to the thread when exception hits, and how I can "save" the thread so it can continue?

Upvotes: 1

Views: 550

Answers (2)

Tigran
Tigran

Reputation: 62246

Becasue you throw an exception, so the exception propagates on top of the stack and break execution of the source thread.

catch (Exception exception)
{
    var mail = new MailService();
    mail.SendExeption("Error has accured in GetJobs", exception);
    throw; //THIS LINE !
}

You can use an event to raise it, say, ExceptionCaught(..) and listen for that event inside your program.

Upvotes: 2

Matten
Matten

Reputation: 17631

Just remove the throw; at the end of your catch clause.

From MSDN:

A throw statement can be used in a catch block to re-throw the exception that is caught by the catch statement.

So you're rethrowing the caught exception which causes the thread to interrupt, never executing again...

More information: What happens when a .NET thread throws an exception?

Upvotes: 1

Related Questions