CODEWITHSUNDEEP
javascriptcallbacksetinterval
computer_smile
computer_smile

Reputation: 2247

Why does the setInterval callback execute only once?

I have this counter I made but I want it to run forever, it's really simple, what am I doing wrong here?

function timer() {
  console.log("timer!")
}

window.setInterval(timer(), 1000)

Upvotes: 83

Views: 66571

Answers (2)

Koen Peters
Koen Peters

Reputation: 12916

You used a function call instead of a function reference as the first parameter of the setInterval. Do it like this:

function timer() {
  console.log("timer!");
}

window.setInterval(timer, 1000);

Or shorter (but when the function gets bigger also less readable):

window.setInterval( function() {
  console.log("timer!");
}, 1000)

Or even shorter, using an arrow function expression:

window.setInterval(() => {
  console.log("timer!");
}, 1000)

Upvotes: 129

Bakudan
Bakudan

Reputation: 19492

setInterval and setTimeout must be used with callbacks, like:

setInterval(timer, 1000);

or unnamed functions:

setInterval( function() { console.log("timer!"); }, 1000 );

Why your code is not working - when you pass a function as argument to another function with brackets e.g. doSomething ( someFunc() ) you are passing the result of the function.

When the function is passed as object e.g. doSomething ( someFunc ) you are passing a callback. This way someFunc is passed as reference and it is executed somewhere in the calling function. This is the same as the pointers to functions in other languages.

A common mistake is to use the these two functions as shown at w3schools. This makes an implicit call to eval.

Upvotes: 14

Related Questions