Image upload popup in ckeditor is not woking in Google chrome

Question

When I click browse server in ckeditor the image browser popup doesnt appear.I am facing problem only in Google Chrome.I am using 18.0.1025.152 m verion of Google Chrome

I have made changes in ckeditor/plugins/popup/plugin.js

    try
    {
        // Chrome 18 is problematic, but it's not really needed here (#8855).
        var ua = navigator.userAgent.toLowerCase();
        if ( ua.indexOf('chrome/18' ) == -1 )
        {
            popupWindow.moveTo( left, top );
            popupWindow.resizeTo( width, height );
        }
        popupWindow.focus();
        popupWindow.location.href = url;
    }
    catch ( e )
    {
        popupWindow = window.open( url, null, options, true );
    }

I followed this link enter link description here But I am unable to resolve the issue.Can anyone help

Answer 1

I am using opencart 1.5.1.3 ckeditor. I edit the /admin/view/javascript/ckeditor/ckeditor.js and re-align the javascript code with http://jsbeautifier.org/

I have tried with the patch from ckeditor community and little modifications. It works! http://dev.ckeditor.com/ticket/8855

So if anyone has face the similar issue like me in opencart you can try with below changes.

+++ b/v1.5.1.3/admin/view/javascript/ckeditor/ckeditor.js
@@ -9190,8 +9190,21 @@ For licensing, see LICENSE.html or http://ckeditor.com/license
         var s = window.open('', null, p, true);
         if (!s) return false;
         try {
-             s.moveTo(r, q);
-             s.resizeTo(n, o);
+             // s.moveTo(r, q);
+             // s.resizeTo(n, o); 
+             // Chrome 18 is problematic, but it's not really needed here (#8855). 
+             var ua = navigator.userAgent.toLowerCase(); 
+             var useResize = true; 
+             if (ua.indexOf('chrome') > -1) { 
+                 var chromeVersion = ua.replace(/^.*chrome\/([\d]+).*$/i, '$1') 
+                 if(chromeVersion >= 18) { 
+                     useResize = false; 
+                 } 
+             }  
+             if (useResize) {
+                 s.moveTo( r, q ); 
+                 s.resizeTo( n, o ); 
+             } 
              s.focus();
              s.location.href = m;
         } catch (t) { 

Answer 2

I'm using the CKEditor 3.6.2 that comes bundled with primefaces-extensions, so upgrading is not that easy. But executing the following fix against the page also worked. I pasted it in the config file, to be sure that it is fired after the CKEDITOR variable is initialized.

    CKEDITOR.editor.prototype['popup'] = function( url, width, height, options ) {
        width = width || '80%';
        height = height || '70%';

        if ( typeof width == 'string' && width.length > 1 && width.substr( width.length - 1, 1 ) == '%' )
            width = parseInt( window.screen.width * parseInt( width, 10 ) / 100, 10 );

        if ( typeof height == 'string' && height.length > 1 && height.substr( height.length - 1, 1 ) == '%' )
            height = parseInt( window.screen.height * parseInt( height, 10 ) / 100, 10 );

        if ( width < 640 )
            width = 640;

        if ( height < 420 )
            height = 420;

        var top = parseInt( ( window.screen.height - height ) / 2, 10 ),
                left = parseInt( ( window.screen.width  - width ) / 2, 10 );

        options = ( options || 'location=no,menubar=no,toolbar=no,dependent=yes,minimizable=no,modal=yes,alwaysRaised=yes,resizable=yes,scrollbars=yes' ) +
                ',width='  + width +
                ',height=' + height +
                ',top='  + top +
                ',left=' + left;

        var popupWindow = window.open( '', null, options, true );

        // Blocked by a popup blocker.
        if ( !popupWindow )
            return false;

        try
        {
            // Chrome 18 is problematic, but it's not really needed here (#8855).
            var ua = navigator.userAgent.toLowerCase();
            if ( ua.indexOf( ' chrome/18' ) == -1 )
            {
                popupWindow.moveTo( left, top );
                popupWindow.resizeTo( width, height );
            }
            popupWindow.focus();
            popupWindow.location.href = url;
        }
        catch ( e )
        {
            popupWindow = window.open( url, null, options, true );
        }

        return true;
    }


    $(document).ready(
            function() {
                setContentHeight();
                makeInstructionsTogglable();
                window.onbeforeunload = function() {
                    if (editor.isDirty()) {
                        return "Are you sure you want to navigate away? You have unsaved changes."
                    }
                };
            }
    );
    $(window).resize(function() {
        setContentHeight();
    });

Answer 3

If you edit the source files you have to repackage them again. It's much simpler to update to CKEditor 3.6.3 and get all the other bug fixes.