JSF page ends in a redirect loop

Question

My browser is always returning a redirect loop and I have no idea why, it looks like when I access login.html it is calling some of my methods.

Here is the login.html file:


    

        
            
                
                    
                        
                            Bem vindo a Sergio's
                            

                            Preencha os campos abaixo para entrar no sistema.
                            
                                Usuário
                                
                                    
                                    
                                
                            
                            
                                Senha

And here is the LoginController:

package com.erp3.gui.controllers;

import java.io.IOException;
import javax.faces.application.FacesMessage;
import javax.faces.bean.ManagedBean;
import javax.faces.context.ExternalContext;
import javax.faces.context.FacesContext;

@ManagedBean
public class LoginController {

    public Boolean isLoggedIn = false;
    private String username;
    private String password;
    private FacesMessage facesMessage;
    public ExternalContext externalContent;

    public String getPassword() {
        return password;
    }

    public void setPassword(String password) {
        this.password = password;
    }

    public String getUsername() {
        return username;
    }

    public void setUsername(String username) {
        this.username = username;
    }

    public Boolean getIsLoggedIn() {
        return isLoggedIn;
    }

    public void setIsLoggedIn(Boolean isLoggedIn) {
        this.isLoggedIn = isLoggedIn;
    }

    public void login() throws IOException {
        if (this.getUsername().equals("daniel") && this.getPassword().equals("123")) {
            this.isLoggedIn = true;
            externalContent = FacesContext.getCurrentInstance().getExternalContext();
            externalContent.getSessionMap().put("loginController", this);
            externalContent.redirect(externalContent.getRequestContextPath() + "/views/home.html");
        } else {
            this.isLoggedIn = false;
            facesMessage = new FacesMessage(FacesMessage.SEVERITY_ERROR, "Usuário ou senha inválida.", username);
            FacesContext.getCurrentInstance().addMessage(null, facesMessage);
            externalContent.redirect(externalContent.getRequestContextPath() + "/views/login.htm");
        }
    }

    public void logOut() throws IOException {
        externalContent = FacesContext.getCurrentInstance().getExternalContext();
        externalContent.getSessionMap().remove("loginController");
        externalContent.redirect(externalContent.getRequestContextPath() + "/views/login.html");
    }

}

I have a master.html that is my template and it is calling a top.html with this content:


    
        
            
                
                    
                    
                    
                
                Project name
                
                    
                        
                        
                    
                    
                        Conta
                        
                        Sair
                    
                
                
                    
                        Home
                        About
                        Contact

BalusC · Accepted Answer

EL expressions in template text are immediately evaluated during render response and treated as value expressions. I.e. their return value is been printed as part of HTML output. "Plain vanilla" HTML is also template text. So the following

Sair

will basically invoke the method, print its returned value as href URL during render response. The resulting HTML is then:

Sair

(yes, the href is empty because you actually returned void instead of a valid String)

But inside that method you're telling JSF to redirect to the login page and hence it ends up in an infinite loop.

This is not what you actually want. You intend to invoke it as a backing bean action method. You should be using fullworthy JSF UICommand component for this, such as .

This way you can also change your logOut() method to return a fullworthy navigation outcome:

public String logOut() {
    FacesContext.getCurrentInstance().getExternalContext().invalidateSession();
    return "/views/login.html?faces-redirect=true";
}

The ExternalContext#redirect() is supposed to be used only when you want to redirect to a non-JSF URL, or when you're actually not inside an action method.

JSF page ends in a redirect loop

Answers (2)

Related Questions