Reputation: 7412
I thought I understood EF, particularly in terms of excrutiatingly simple CRUD, but I may be wrong.
I have an ObjectContext/Repository pattern, and in this case a VatCode entity which has a collection of VatRates.
VatCode 1--* VatRate
I want to provide the functionality for CRUDing these entities. This is in a WPF application, and is operating "disconnected" in that I am not holding DB connections open unnecassarily. I prefer the in/out method of database access. This is shown in the following integration test:
[TestMethod()]
public void AddVatRateAndSaveVatCodeTest()
{
VatCode vatCode=null;
DateTime expectedDateFrom = DateTime.Now.AddDays(1).Date;
using (SopEntities sopEntities = EntitiesFactory.Create(Properties.Resources.ConnectionString))
{
VatRepository target = new VatRepository(sopEntities);
vatCode = target.SingleOrDefault(q => q.Key == "X4");
Assert.IsNotNull(vatCode);
}
// mimick offline editing/disconnect
using (SopEntities sopEntities = EntitiesFactory.Create(Properties.Resources.ConnectionString))
{
VatRepository target = new VatRepository(sopEntities);
vatCode.VatRates.Add(new VatRate()
{
DateFrom=expectedDateFrom,
Rate=20
});
target.Attach(vatCode);
target.SaveChanges();
}
using (SopEntities sopEntities=EntitiesFactory.Create(Properties.Resources.ConnectionString))
{
VatRepository vatRepository=new VatRepository(sopEntities);
VatCode actual=vatRepository.SingleOrDefault(q=>q.Key=="X3");
Assert.IsNotNull(actual);
Assert.AreEqual(vatCode.VatRates.Count,actual.VatRates.Count);
Assert.AreEqual(expectedDateFrom,actual.VatRates.OrderBy(q=>q.DateFrom).Last().DateFrom);
}
}
The code is simple. It retrieves a known existing entity and assigns it to vatCode. This entity is then passed around in the ViewModel on the UI, and re-saved. In this test, I mimmick this by opening a new context. This is exactly how I would in the UI, so I am proving it here.
However, on calling the Attach() method of the vatRepository, which has the following method body:
public void Attach(TEntity entity)
{
if (entity == null)
throw new ArgumentNullException("entity");
_context.ObjectStateManager.ChangeObjectState(entity, System.Data.EntityState.Modified); // exception here
_objectSet.Attach(entity);
}
I get the exception below on the ChangeObjectState method (which I call because the entity was disconnected from the original context scope).
System.InvalidOperationException was unhandled by user code
Message=The ObjectStateManager does not contain an ObjectStateEntry with a reference to an object of type 'Mac.Sop.Core.Data.VatCode'.
I did consider that maybe my XML in the EF model was not correct (considering reference to 'Mac.Sop.Core.Data.VatCode'), but looking through it I cannot find any issues and these entities follow similar patterns with my other entities.
Update: My EF model. I can't find any reference to 'Mac.Sop.Core.Data.VatCode':
<?xml version="1.0" encoding="utf-8"?>
<edmx:Edmx Version="2.0" xmlns:edmx="http://schemas.microsoft.com/ado/2008/10/edmx">
<edmx:Runtime>
<edmx:StorageModels>
<Schema Namespace="Model.Store" Alias="Self" Provider="System.Data.SqlClient" ProviderManifestToken="2008" xmlns:store="http://schemas.microsoft.com/ado/2007/12/edm/EntityStoreSchemaGenerator" xmlns="http://schemas.microsoft.com/ado/2009/02/edm/ssdl">
<EntityContainer Name="ModelStoreContainer">
<EntitySet Name="MacsSop_VATCode" EntityType="Model.Store.MacsSop_VATCode" store:Type="Tables" Schema="dbo" />
<EntitySet Name="MacsSop_VATRate" EntityType="Model.Store.MacsSop_VATRate" store:Type="Tables" Schema="dbo" />
<AssociationSet Name="FK_MacsSop_VATRate_MacsSop_VATCode" Association="Model.Store.FK_MacsSop_VATRate_MacsSop_VATCode">
<End Role="MacsSop_VATCode" EntitySet="MacsSop_VATCode" />
<End Role="MacsSop_VATRate" EntitySet="MacsSop_VATRate" />
</AssociationSet>
</EntityContainer>
<EntityType Name="MacsSop_VATCode">
<Key>
<PropertyRef Name="Key" />
</Key>
<Property Name="Key" Type="varchar" Nullable="false" MaxLength="3" />
<Property Name="Name" Type="nvarchar" Nullable="false" MaxLength="128" />
</EntityType>
<EntityType Name="MacsSop_VATRate">
<Key>
<PropertyRef Name="ID" />
</Key>
<Property Name="ID" Type="int" Nullable="false" StoreGeneratedPattern="Identity" />
<Property Name="Key" Type="varchar" Nullable="false" MaxLength="3" />
<Property Name="DateFrom" Type="datetime" Nullable="false" />
<Property Name="Rate" Type="decimal" Nullable="false" Scale="2" />
</EntityType>
<Association Name="FK_MacsSop_VATRate_MacsSop_VATCode">
<End Role="MacsSop_VATCode" Type="Model.Store.MacsSop_VATCode" Multiplicity="1" />
<End Role="MacsSop_VATRate" Type="Model.Store.MacsSop_VATRate" Multiplicity="*" />
<ReferentialConstraint>
<Principal Role="MacsSop_VATCode">
<PropertyRef Name="Key" />
</Principal>
<Dependent Role="MacsSop_VATRate">
<PropertyRef Name="Key" />
</Dependent>
</ReferentialConstraint>
</Association>
</Schema></edmx:StorageModels>
<!-- CSDL content -->
<edmx:ConceptualModels>
<Schema Namespace="Model" Alias="Self" xmlns:annotation="http://schemas.microsoft.com/ado/2009/02/edm/annotation" xmlns="http://schemas.microsoft.com/ado/2008/09/edm">
<EntityContainer Name="SopEntities" annotation:LazyLoadingEnabled="true" >
<EntitySet Name="VatCodes" EntityType="Model.VatCode" />
<EntitySet Name="VatRates" EntityType="Model.VatRate" />
<AssociationSet Name="FK_MacsSop_VATRate_MacsSop_VATCode" Association="Model.FK_MacsSop_VATRate_MacsSop_VATCode">
<End Role="MacsSop_VATCode" EntitySet="VatCodes" />
<End Role="MacsSop_VATRate" EntitySet="VatRates" />
</AssociationSet>
</EntityContainer>
<EntityType Name="VatCode">
<Key>
<PropertyRef Name="Key" />
</Key>
<Property Type="String" Name="Key" Nullable="false" MaxLength="3" FixedLength="false" Unicode="false" />
<Property Type="String" Name="Name" Nullable="false" MaxLength="128" FixedLength="false" Unicode="true" />
<NavigationProperty Name="VatRates" Relationship="Model.FK_MacsSop_VATRate_MacsSop_VATCode" FromRole="MacsSop_VATCode" ToRole="MacsSop_VATRate" />
</EntityType>
<EntityType Name="VatRate">
<Key>
<PropertyRef Name="ID" />
</Key>
<Property Type="Int32" Name="ID" Nullable="false" annotation:StoreGeneratedPattern="Identity" />
<Property Type="String" Name="Key" Nullable="false" MaxLength="3" FixedLength="false" Unicode="false" />
<Property Type="DateTime" Name="DateFrom" Nullable="false" />
<Property Type="Decimal" Name="Rate" Nullable="false" Precision="18" Scale="2" />
<NavigationProperty Name="VatCode" Relationship="Model.FK_MacsSop_VATRate_MacsSop_VATCode" FromRole="MacsSop_VATRate" ToRole="MacsSop_VATCode" />
</EntityType>
<Association Name="FK_MacsSop_VATRate_MacsSop_VATCode">
<End Type="Model.VatCode" Role="MacsSop_VATCode" Multiplicity="1" />
<End Type="Model.VatRate" Role="MacsSop_VATRate" Multiplicity="*" />
<ReferentialConstraint>
<Principal Role="MacsSop_VATCode">
<PropertyRef Name="Key" />
</Principal>
<Dependent Role="MacsSop_VATRate">
<PropertyRef Name="Key" />
</Dependent>
</ReferentialConstraint>
</Association>
</Schema>
</edmx:ConceptualModels>
<!-- C-S mapping content -->
<edmx:Mappings>
<Mapping Space="C-S" xmlns="http://schemas.microsoft.com/ado/2008/09/mapping/cs">
<EntityContainerMapping StorageEntityContainer="ModelStoreContainer" CdmEntityContainer="SopEntities" >
<EntitySetMapping Name="VatCodes">
<EntityTypeMapping TypeName="Model.VatCode">
<MappingFragment StoreEntitySet="MacsSop_VATCode">
<ScalarProperty Name="Name" ColumnName="Name" />
<ScalarProperty Name="Key" ColumnName="Key" />
</MappingFragment>
</EntityTypeMapping>
</EntitySetMapping>
<EntitySetMapping Name="VatRates">
<EntityTypeMapping TypeName="Model.VatRate">
<MappingFragment StoreEntitySet="MacsSop_VATRate">
<ScalarProperty Name="Rate" ColumnName="Rate" />
<ScalarProperty Name="DateFrom" ColumnName="DateFrom" />
<ScalarProperty Name="Key" ColumnName="Key" />
<ScalarProperty Name="ID" ColumnName="ID" />
</MappingFragment>
</EntityTypeMapping>
</EntitySetMapping>
</EntityContainerMapping>
</Mapping>
</edmx:Mappings>
</edmx:Runtime>
</edmx:Edmx>
This needs to work in this disconnected fashion and it must be possible as WCF/ASP.NET implementations of this pattern obviously exist!
Upvotes: 3
Views: 15384
Reputation: 32437
Swap the Attach
and ChangeObjectState
lines because you need to add the entity to ObjectStateManager
in order to change the state.
public void Attach(TEntity entity)
{
if (entity == null)
throw new ArgumentNullException("entity");
_objectSet.Attach(entity);
_context.ObjectStateManager.ChangeObjectState(entity, EntityState.Modified);
}
Upvotes: 12