CODEWITHSUNDEEP
c#winforms
Valien
Valien

Reputation: 1145

C# How To: Trying to call button twice in same class?

Did some searches here & on the 'net and haven't found a good answer yet. What I'm trying to do is call a button twice within the same class in C#.

Here's my scenario -

I have a form with a button that says "Go". When I click it the 1st time, it runs through some 'for' loops (non-stop) to display a color range. At the same time I set the button1.Text properties to "Stop". I would like to be able to click the button a 2nd time and when that happens I would like the program to stop. Basically a stop-and-go button. I know how to do it with 2 button events, but would like to utilize 1 button.

Right now the only way to end the program is the X button on the form.

I've tried different things and haven't had much luck so far so wanted to ask the gurus here how to do it.

BTW, this is a modification of a Head First Labs C# book exercise.

Thanks!

~Allen

Upvotes: 0

Views: 1634

Answers (7)

John Donoghue
John Donoghue

Reputation: 63

Cerebrus is right about using the Background Worker thread. However if you are doing a WPF app then it won't be able to update the UI directly. To get around this you can call Dispatcher.BeginInvoke on the main control/window.

Given code like:

Private Delegate Sub UpdateUIDelegate(<arguments>)

Private Sub CallUpdateUI(<arguments>)
  control.Dispatcher.BeginInvoke(Windows.Threading.DispatcherPriority.Background, New UpdateUIDelegate(AddressOf UpdateUI), <arguments>)
End Sub

Private Sub UpdateUI(<arguments>)
  'update the UI
End Sub

You can call CallUpdateUI from the Background Worker thread and it will get the main thread to perform UpdateUI.

Upvotes: 1

JMarsch
JMarsch

Reputation: 21753

Are you getting your second button click event? Put a breakpoint in your click handler and run your code. When you click the second time, do you ever hit your breakpoint?

If your loop is running continuously, and it is in your button click handler, then your loop is running in the UI thread. You probably don't get to "see" the second button click until after the loop is completed. In addition to the branch code that you see above, try either inserting a DoEvents in your loop processing (this is a place where your loop will temporarly give up control so that messages can be processed). Or, (better) have a look at the backgroundworker class -- do most of your processing in a different thread, so that you UI can remain responsive to button clicks.

Upvotes: 1

Greg D
Greg D

Reputation: 44076

One simple solution would be to add a boolean member to your form that is, e.g., true when the button says "Go" and false when the button says "Stop".

Then, in your button's event handler, check that boolean value. If the value is true, then start your operation and set the value to false when you change the button's text to say "stop". Vice-versa for the other case. :)

There are other techniques that I might prefer if this were production code, perhaps including considering the design of the form more carefully, but as this is clearly a learning exercise I believe that a simple boolean flag indicating the current state of the form is just what you're looking for.

Note that I would strongly discourage you from checking the value of the button text to determine what state the object is in. Whenever possible, as a general rule of good design, you want your visual state to be "decoupled" from your underlying object's state. That is to say, your visual widgets can depend on your underlying objects, but your underlying objects should not depend on your visual widgets. If you tested the text of the button, your underlying logic would depend on your visual state and that would violate this general rule.

If your problem is related to the fact that you can't cancel the operation while it's being performed, you'll want to look into using a BackgroundWorker to perform your long-running activity.

Upvotes: 3

Cerebrus
Cerebrus

Reputation: 25775

You would need to use Multithreading (launch the process intensive code asynchronously in a separate thread), for instance, using the BackgroundWorker object in .NET 2+. This would be necessary because your UI will not respond to the user's click until the loop running in the Start method is completed. It is quite irrelevant if you use the same button or another one to toggle the process, because the processor is busy processing the loop.

The BackgroundWorker has a property called WorkerSupportsCancellation which needs to be true in this scenario. When the user clicks Stop you would invoke the CancelAsync method of the BackgroundWorker.

See MSDN for a good example. Also DreamInCode has a good tutorial which seems quite similar to your requirement.

Upvotes: 7

Patrick McDonald
Patrick McDonald

Reputation: 65421

Another option would be to check the current text on your button to determine what to do:

void btnStartStop_Click(Object sender, EventArgs e) 
{
    if (btnStartStop.Text == "Go")
    {
        btnStartStop.Text = "Stop";

        // Go code here

    }
    else 
    {
        btnStartStop.Text = "Go";

        // Stop code here

    }
}

Upvotes: 1

Chris Doggett
Chris Doggett

Reputation: 20757

You could set the Tag property on the button to a boolean indicating whether the next action should be "Stop" or "Go", and reset it each time you click the button. It's an Object property, though, so you'll have to cast it to bool when you read it.

Upvotes: 0

Adrian Godong
Adrian Godong

Reputation: 8921

Why not create two buttons, hide one when the other is visible? That should be a lot of easier to handle.

Or you can add a bool field to indicate which operation branch to execute.

Upvotes: 3

Related Questions