CODEWITHSUNDEEP
javaandroidbitmaparraysserializable
Cyberon
Cyberon

Reputation: 289

decodeByteArray and copyPixelsToBuffer not working. SkImageDecoder::Factory returned null

I have a class TouchPoint which implements Serializable and because it contains Bitmap I wrote writeObject and readObject for that class:

private void writeObject(ObjectOutputStream oos) throws IOException {
    long t1 = System.currentTimeMillis();
    oos.defaultWriteObject();
    if(_bmp!=null){
        int bytes = _bmp.getWidth()*_bmp.getHeight()*4;

        ByteBuffer buffer = ByteBuffer.allocate(bytes); 
        _bmp.copyPixelsToBuffer(buffer);

        byte[] array = buffer.array();      

        oos.writeObject(array);

    }
    Log.v("PaintFX","Elapsed Time: "+(System.currentTimeMillis()-t1));
}

private void readObject(ObjectInputStream ois) throws IOException, ClassNotFoundException{
    ois.defaultReadObject();
    byte[] data = (byte[]) ois.readObject();
    if(data != null && data.length > 0){
        _bmp = BitmapFactory.decodeByteArray(data, 0, data.length);
    }
}

The problem is that I get

SkImageDecoder::Factory returned null

So how can I fix it. I know that possible solution is to change writeObject() to

ByteArrayOutputStream byteStream = new ByteArrayOutputStream();
_bmp.compress(Bitmap.CompressFormat.PNG, 100, byteStream);
oos.writeObject(byteStream.toByteArray);

BUT this method is slower almost 10+ times.

UPDATE Find out that the actual problem is that after 

buffer.array();

All byte[] array elements are: 0

Upvotes: 8

Views: 5697

Answers (2)

Cyberon
Cyberon

Reputation: 289

Finally I find a way to make it work and be faster at the same time. I was encountered two issues using this method:

  1. I should pass the Bitmap.Config param also, without that I can't decode the byte array
  2. _bmp.compress and _bmp.copyPixelsToBuffer give different arrays so I couldn't use decodeByteArray.

I solved them this way

private void writeObject(ObjectOutputStream oos) throws IOException {
    oos.defaultWriteObject();

    if(_bmp!=null){
        int bytes = _bmp.getWidth()*_bmp.getHeight()*4;

        ByteBuffer buffer = ByteBuffer.allocate(bytes);
        _bmp.copyPixelsToBuffer(buffer);

        byte[] array = new byte[bytes]; // looks like this is extraneous memory allocation

        if (buffer.hasArray()) {
            try{
                array = buffer.array();
            } catch (BufferUnderflowException e) {
                e.printStackTrace();
            }
        }

        String configName = _bmp.getConfig().name();

        oos.writeObject(array);
        oos.writeInt(_bmp.getWidth());
        oos.writeInt(_bmp.getHeight());
        oos.writeObject(configName);
    } else {
        oos.writeObject(null);
    }
}

private void readObject(ObjectInputStream ois) throws IOException, ClassNotFoundException{
    ois.defaultReadObject();

    byte[] data = (byte[]) ois.readObject();
    if (data != null) {
        int w = ois.readInt();
        int h = ois.readInt();
        String configName = (String) ois.readObject();

        Bitmap.Config configBmp = Bitmap.Config.valueOf(configName);
        Bitmap bitmap_tmp = Bitmap.createBitmap(w, h, configBmp);
        ByteBuffer buffer = ByteBuffer.wrap(data);

        bitmap_tmp.copyPixelsFromBuffer(buffer);

        _bmp = bitmap_tmp.copy(configBmp,true);

        bitmap_tmp.recycle();
    } else {
        _bmp = null;
    }
}

This is enough fast for me - about 15x faster then the bmp.compress way. hope this helps :)

Upvotes: 7

Klaasvaak
Klaasvaak

Reputation: 5644

Bitmap to byte[]:

Bitmap bmp; // your bitmap
ByteArrayOutputStream stream = new ByteArrayOutputStream();
bmp.compress(Bitmap.CompressFormat.PNG, 100, stream);
byte[] byteArray = stream.toByteArray();

Use Bufferedstreams for better performance.

Upvotes: 1

Related Questions