CODEWITHSUNDEEP
c++static-methods
Sait
Sait

Reputation: 19805

Static function declared but not defined in C++

I'm getting an error from the following code using C++.

Main.cpp

#include "file.h"

int main()
{
   int k = GetInteger();
   return 0;
}

File.h

static int GetInteger();

File.cpp

#include "file.h"

static int GetInteger()
{
   return 1;
}

The error I get:

Error C2129: static function 'int GetInteger(void)' declared but not defined.

I've read the famous article "Organizing Code File in C and C++", but don't understand what is wrong with this code.

Upvotes: 88

Views: 88604

Answers (7)

Andrew
Andrew

Reputation: 1470

Consider using namespaces...

for logical sections of code that don't require internal member variables. Meaning, your GetInteger() function doesn't require an internal constant variable to be referenced. In order to keep your functions organized in your code, consider using namespaces. This keeps function names from conflicting (which will save your hours of headache with possible LNK errors). The code still works in the way you've set up and still works within the confines of the accepted answer. Additionally, your namespace name can help you quickly debug.

Main.cpp

#include "file.h"

int main()
{
   int k = HELPERS::GetInteger();
   return 0;
}

File.h

namespace HELPERS
{
    int GetInteger();
}

File.cpp

#include "file.h"

int HELPERS::GetInteger()
{
   return 1;
}

Upvotes: 1

log0
log0

Reputation: 10917

If everything is in the same translation unit it should work. You probably did not compile File.cpp into the same unit as Main.cpp.

g++ -Wall File.cpp Main.cpp

If each file is compiled separately the function must be made extern to be used from a different translation unit.

extern int GetInteger();

which is the same as 

int GetInteger();

Upvotes: 3

HBY4PI
HBY4PI

Reputation: 89

From my understanding, static functions are name mangled with the filename in which they are defined so when you include file.h in main.cpp, GetInteger() get mangled with main.cpp though you have defined GetInteger() in file.cpp but since it is static it gets mangled too and linker cannot find the definition of GetInteger() as no function by this name exists.

I believe lesson learnt is don't declare static functions in headerfile as are not intended to be a part of interface.

Upvotes: 3

James Kanze
James Kanze

Reputation: 153899

Because in this case, static means that the name of the function has internal linkage; that GetInteger in one translation unit is unrelated to GetInteger in any other translation unit. The keyword static is overloaded: in some cases, it affects lifetime, and in others, binding. It's particularly confusing here, because "static" is also the name of a lifetime. Functions, and data declared at namespace scope, always have static lifetime; when static appears in their declaration, it causes internal binding, instead of external.

Upvotes: 9

LeleDumbo
LeleDumbo

Reputation: 9340

functions declared as static arelocal to the containing file. Therefore, you have to define the function in the same file as the ones who call it. If you want to make it callable from other file, you must NOT declare it as static.

Upvotes: 5

HighCommander4
HighCommander4

Reputation: 52739

In C++, static at global/namespace scope means the function/variable is only used in the translation unit where it is defined, not in other translation units.

Here you are trying to use a static function from a different translation unit (Main.cpp) than the one in which it is defined (File.cpp).

Remove the static and it should work fine.

Upvotes: 157

Luchian Grigore
Luchian Grigore

Reputation: 258548

Change

static int GetInteger();

to

int GetInteger();

static in this case gives the method internal linkeage, meaning that you can only use it in the translation unit where you define it.

You define it in File.cpp and try to use it in main.cpp, but main doesn't have a definition for it, since you declared it static.

Upvotes: 29

Related Questions