CODEWITHSUNDEEP
javascript
lisovaccaro
lisovaccaro

Reputation: 33996

Pass variable to external javascript?

I have a plugin which shows posts from a certain city:

<div id='banner-root' style="height: 50px; width: 385px;"></div>
<script src="http://lujanventas.com/plugins/banner.js" type="text/javascript"></script>

I need to pass the cityID to the external javascript. I'm already getting height and width on the external .js by simply checking the banner-root element.

How do I pass the and ID? Also it would be nice if it was clear that you are passing the cityID

Upvotes: 1

Views: 4699

Answers (2)

lukas.pukenis
lukas.pukenis

Reputation: 13597

When I had to do so, I used this:

<script type="text/javascript">var cityID = x;</script>
<script src="http://lujanventas.com/plugins/banner.js" type="text/javascript"></script>

Then I can access cityID in the banner.js script

EDIT

One of Javascript flaws are - everything by default is in global scope.

This means in the example above cityID is devined in global namespace - window. This is great for example when I want to reach this value from banner.js but bad by design as missed var statement in function body can overwrite global variable.

Upvotes: 2

Esailija
Esailija

Reputation: 140236

You don't really pass the width and height to the script according to your comments.. you can use the same style with cityId like so:

<div id='banner-root' style="height: 50px; width: 385px;" data-cityId="32"></div>

You can then retrieve it with 

document.getElementById("banner-root").getAttribute("data-cityId");

Upvotes: 2

Related Questions