CODEWITHSUNDEEP
javascripthtmloptimizationcompatibility
4wk_
4wk_

Reputation: 2733

Best Practice for JS - window.open() in href or in onclick?

Just a question about optimization, between :

<a href="#" onClick="javascript:window.open('myUrl.com');">link-1</a>

and :

<a href="javascript:window.open('myUrlBis.com');">link-2</a>

Is one better than the other ? Or more compatible ? Thanks.

Upvotes: 5

Views: 48240

Answers (4)

Firos Shamsudeen
Firos Shamsudeen

Reputation: 71

Below code should be fine.

<a href="javascript:void(0);"  onclick="window.open(url)">

Found issue in IE (version:11) with below code

<a onclick="javascript:window.open(url)">

Problem: The parent window is getting refreshed in IE when we have javascript window.open code in href attribute.

Upvotes: -1

epascarello
epascarello

Reputation: 207511

No JavaScript

<a target="_blank" href="myUrlBis.com">link</a>

With JavaScript

<a target="_blank" href="http://www.example.com" id="myLink">link</a>
<script>
    document.getElementById("myLink").onclick = function(){ //attach click event to link
        var winPop = window.open(this.href);  //`this` is reference to link, get href
        return false;  //prevent click event from clicking the link
    }
</script>

JSFiddle Example

Upvotes: 0

Ruan Mendes
Ruan Mendes

Reputation: 92274

Neither one

Make it a regular link using href and target

<a id='my-link' target="_blank" href="http://myUrlBis.com">link-2</a>

If you need to do some processing of the click with JavaScript, you can use the following

document.getElementById("my-link").onclick = function(e) {
  // Do some processing here, maybe 
  window.location = this.href
  // Return false to prevent the default action if you did redirect with script
  return false;
}

Upvotes: 3

T.J. Crowder
T.J. Crowder

Reputation: 1074335

Best practice is to use the target attribute:

<a href="http://myUrl.com" target="_blank">link-1</a>

If that doesn't suit, a click handler (ideally not assigned via attribute) would be my take.

Upvotes: 17

Related Questions