CODEWITHSUNDEEP
c++algorithmshortest-pathbreadth-first-search
ka4tik
ka4tik

Reputation: 77

Shortest distance using BFS

I am trying to solve this SPOJ problem. The question asks to find the shortest path for each black(1) pixel.

Since it is a unweighted graph I used BFS.

for input:

3 3
010
000
000

it's giving:

323
434
343

instead of:

101
212
323

This is my code

#include<iostream>
#include<queue>
#include<string.h>
using namespace std;
typedef pair < int, int >ii;
int R, C, i, j;
queue < ii > myQueue;

int visit[100][100];
int dist[100][100];
void bfs(ii s)
{
    int i, j;
    int count = 0;
    ii node;
    memset(visit, 0, sizeof(visit));
    memset(dist, 0, sizeof(dist));
    myQueue.push(s);
    dist[node.first][node.second] = 0;

    while (!myQueue.empty()) {
        node = myQueue.front();
        myQueue.pop();
        if (visit[node.first][node.second])
            continue;
        visit[node.first][node.second] = 1;

        //cout << node.first << " " << node.second << "\n";
        i = node.first;
        j = node.second;

        if (j - 1 < R && j - 1 >= 0) {
            myQueue.push(make_pair(i, j - 1));
            if(dist[i][j - 1] == 0)
            dist[i][j - 1] = dist[i][j] + 1;
        }
        if (j + 1 < R && j + 1 >= 0) {
            myQueue.push(make_pair(i, j + 1));
            if(dist[i][j+1] == 0)
            dist[i][j + 1] = dist[i][j] + 1;
        }
        if (i - 1 < C && i - 1 >= 0) {
            myQueue.push(make_pair(i - 1, j));
            if(dist[i-1][j] == 0)
            dist[i - 1][j] = dist[i][j] + 1;
        }
        if (i + 1 < C && i + 1 >= 0) {
            myQueue.push(make_pair(i + 1, j));
            if(dist[i+1][j] == 0)
            dist[i + 1][j] = dist[i][j] + 1;
        }
    }
}

int main()
{
    char input[100][100];
    scanf("%d %d", &R, &C);
    for (i = 0; i < R; i++)
        scanf("%s", &input[i]);
    int GRID[R][C];
    for (i = 0; i < R; i++)
        for (j = 0; j < C; j++)
            GRID[i][j] = input[i][j] - '0';
    for (i = 0; i < R; i++)
        for (j = 0; j < C; j++) {
            if (GRID[i][j] == 1)
                bfs(make_pair(i, j));
        }
    for (i = 0; i < R; i++) {
        for (j = 0; j < C; j++) {
            printf("%d", dist[i][j]);
        }
        printf("\n");
    }
}

ideone

Upvotes: 0

Views: 592

Answers (2)

nav_jan
nav_jan

Reputation: 2553

Try this:

if (j - 1 < R && j - 1 >= 0) {
    myQueue.push(make_pair(i, j - 1));
    if(dist[i][j - 1] == 0)
    dist[i][j - 1] = dist[i][j] + 1;
}

do this for all dist[][].

Upvotes: 3

Oleg Kovalov
Oleg Kovalov

Reputation: 762

You have doubled result may be because you run your BFS twice between paired vertices.

But I'm not sure.

Upvotes: 0

Related Questions