CODEWITHSUNDEEP
javascriptjqueryhtmlcss
João Pedro
João Pedro

Reputation: 978

remove and addClass only works once

I'm developing a menu that has two modes, when the user clicks on one of them the class of a list item changes, I can get it to work at the first mode change but when I try to change back it does not work.

this is my code 

$('#menu ul.mode li.edit').click(function() {
    $('#menu').css('background-image', 'url(images/edit-menu/fundo.png)');
    });
    $('#menu ul.icons li.ummix').removeClass('ummix').addClass('um');


$('#menu ul.mode li.mix').click(function() {
    $('#menu').css('background-image', 'url(images/edit-menu/fundo-mix.gif)');
    $('li.um').removeClass('um').addClass('ummix');

});

the part that doesn't work is

$('#menu ul.icons li.ummix').removeClass('ummix').addClass('um');

My HTML is like this

<div id="menu">
<ul class="mode">
    <li class="edit"><a href="#edit"><img src="images/edit-menu/selected/edit.gif" /></a></li>
    <li class="mix"><a href="#mix"><img src="images/edit-menu/icons/mix.png" /></a></li>
</ul>

<ul class="icons"> 
    <li class="um"></li>
</ul>

Upvotes: 0

Views: 907

Answers (2)

Niet the Dark Absol
Niet the Dark Absol

Reputation: 324750

After you remove the ummix class, the selector no longer applies to those elements. Try adding the um class before removing the ummix one.

Upvotes: 0

Jason McCreary
Jason McCreary

Reputation: 73011

Adding and removing opposite classes becomes unwieldy.

Assuming that unmix and um are opposites of one another, I would encourage you to use just one class. Then check for its existence or nonexistence. At that point you could simply use something like toggleClass().

Upvotes: 1

Related Questions