niao
niao

Reputation: 5070

Should I use WPF converter or trigger?

I was wondering how do you decide when to use converters and when to use triggers. I prefer using triggers for operations on GUI (like showing/hiding controls, changing their appearance etc.).

Some time ago I used a BooleanToVisibilityConverter for this purpose but now, I just don't need it, I do all things connected to the visibility using a triggers and I even started to think "what was the purpose of creating a BooleanToVisibilityConverter by the MS team?". Generally, when it's possible I try to use a declarative way to write the code - in this example - XAML.

What is your opinion of that?

Upvotes: 16

Views: 4777

Answers (5)

akjoshi
akjoshi

Reputation: 15772

I agree with you, I also try to use declarative code in XAML and prefer Triggers instead of Converters.

In most of the scenarios triggers can perform the same work as any converter but Converters can have custom/business logic as pchajer mentioned.

One limitation of Triggers is that Setters in your DataTriggers can only change properties of your UI elements; so, you can't update your ViewModels property with triggers, thats where Converters win, remember the ConvertBack method.

So, you can bind your VM property with a controls Visibility using BooleanToVisibilityConverter and even if your controls visibility is changed by some other means your VM property will get updated; generally it's not required that's why BooleanToVisibilityConverter gets replaced by triggers.

So in short -

Triggers can only perform OneWay operations whereas Converters can perform TwoWay operations

Upvotes: 24

Jdek
Jdek

Reputation: 1

You should always do business related operations in the DomainModel objects, or at least in a ViewModel object. Making some business work in converter is not a good option because Converters are designed to convert a value from one type to another.

Upvotes: 0

Jimmy
Jimmy

Reputation: 3264

In my opinion, you are looking from bottom-up and you just need to look top-down.

Triggers-When a specified condition is fulfilled it "triggers" an execution

Converters-Convert between two incompatible types.

Why do we need a boolean datatype when we can do the same functionality with intergers?

Upvotes: 2

pchajer
pchajer

Reputation: 1584

You can achieve the functionality either by trigger or converter but from my option below possibility can be considered while taking decision

  1. If you are using TDD approach for development then go for converters as you can write test cases.
  2. If there is any business logic better to right code in converter and sometiems which can not be achieved through trigger.

Upvotes: 1

Martin Moser
Martin Moser

Reputation: 6269

In addition to what has been said above I can only add:

  • Triggers sometimes require to duplicate things, e.g. when you have more than one property for triggers you need to specify each an every combination
  • Sometimes you will need code to properly convert from type A to B, then you have to use converters. Triggers are good if the value/property is already exposed from the VM in way, that you can use it for triggers.

Upvotes: 1

Related Questions