CODEWITHSUNDEEP
php
localhost
localhost

Reputation: 440

preg_replace_callback() - Callback inside current object instance

Warning: preg_replace_callback() [function.preg-replace-callback]: Requires argument 2, 'info', to be a valid callback in [...]

public function getDisplay(){
    $info = array_merge($this->info,array());

    return  preg_replace_callback('!\{\{(\w+)\}\}!', 'info', $this->display);
}

In a public function from "MyClass", stopped working when I moved from another class to this one. Which was:

public function getEdit( $type){
    $all_info = $this->info;

    return preg_replace_callback('!\{\{(\w+)\}\}!', 'all_info', $edit_contents);
}

Both are cleaned up, and now I can't retest with previous class because it's already long gone.

I'm sure using variables is not allowed, but it was working, so I'm clueless.

When I do this, as suggested in some stackoverflow thread, but obviously it's not made to be used within objects:

public function getDisplay(){
    $display_info = $this->info;

    function display_info($matches) {
        global $display_info;
        return $display_info[$matches[1]];
    }

    return  preg_replace_callback('!\{\{(\w+)\}\}!', 'display_info', $this->display);
}

So I need some love and guidance cuz php is driving me crazy this week...

Upvotes: 1

Views: 5228

Answers (3)

Tadeck
Tadeck

Reputation: 137410

Instead of using anonymous functions or more complex methods, you can just use one of methods supported for passing callbacks (see the documentation on callbacks):

A method of an instantiated object is passed as an array containing an object at index 0 and the method name at index 1.

To pass "info" method of current object as a callback, just do the following:

array($this, 'info')

and pass it wherever you want to use "info" method as a callback within one of the objects other methods.

Upvotes: 14

DaveRandom
DaveRandom

Reputation: 88697

The correct way to do this would be with a closure:

public function getDisplay() {

    // While $this support in closures has been recently added (>=5.4.0), it's
    // not yet widely available, so we'll get another reference to the current
    // instance into $that first:
    $that = $this;

    // Now we'll write that preg... line of which you speak, with a closure:
    return  preg_replace_callback('!\{\{(\w+)\}\}!', function($matches) use($that) {
        return $that->info[$matches[1]];
    }, $this->display);

}

Upvotes: 4

localhost
localhost

Reputation: 440

This solved it:

public function getDisplay(){
    return  preg_replace_callback('!\{\{(\w+)\}\}!', array(get_class($this), '_preg_replace_callback'), $this->display);
}

private function _preg_replace_callback($matches){
    return $this->info[$matches[1]];
}

I did try this approach before, but didn't use the get_class() function to wrap $this. Oh bother...

Upvotes: 2

Related Questions