CODEWITHSUNDEEP
androidandroid-asynctask
Asaf Nevo
Asaf Nevo

Reputation: 11688

Android AsyncTasks How to Check If activity is still running

I have used AsyncTasks with my application, in order to lazy download and update the UI.

For now my AsyncTasks updates the UI real simply:

protected void onProgressUpdate(String... values) {
        super.onProgressUpdate(values);
        gender.setText(values[0]);
}

My problem is how to check if the activity which the gender TextView rendered from, is still available?

If not, I will get an error and my application will shut down.

Upvotes: 19

Views: 20696

Answers (8)

A. AMAIDI
A. AMAIDI

Reputation: 6849

You can cancel your asynctask in the activity's onDestroy

@Override
protected void onDestroy() {
    asynctask.cancel(true);
    super.onDestroy();
}

and when performing changes you check whether your asynctask has been cancelled(activity destroyed) or not

protected void onProgressUpdate(String... values) {
    super.onProgressUpdate(values);
    if(!isCancelled()) {
         gender.setText(values[0]);
    }
}

Upvotes: 26

Emran Hamza
Emran Hamza

Reputation: 3869

Check whether activity is running or not 

 if (!isFinishing()) {
  // Do whatever you want to do
}

Upvotes: 2

frangulyan
frangulyan

Reputation: 3867

As this part of one training on Android Developers suggests, keep a WeakReference on the UI element that needs to be updated after task is done and check if the reference is null before using it. This helps not only in checking if the UI is still around, but also does not prevent UI elements from being garbage collected.

Upvotes: 1

IanB
IanB

Reputation: 3489

I had a similar problem - essentially I was getting a NPE in an async task after the user had destroyed the fragment. After researching the problem on Stack Overflow, I adopted the following solution:

volatile boolean running;

public void onActivityCreated (Bundle savedInstanceState) {

    super.onActivityCreated(savedInstanceState);

    running=true;
    ...
    }


public void onDestroy() {
    super.onDestroy();

    running=false;
    ...
}

Then, I check "if running" periodically in my async code. I have stress tested this and I am now unable to "break" my activity. This works perfectly and has the advantage of being simpler than some of the solutions I have seen on SO.

Upvotes: 9

Vipul
Vipul

Reputation: 28093

Even though, I have never faced this scenario; I will try to answer your question.

In your case you will need to validate the Context passed to AsyncTask.

You can perform validation

if(null!=mContext)  //Activity still exist!!
{
  gender.setText(values[0]);
}
else //Activity is destroyed
{
   //Take appropriate action!!
}

The advantage will be, if the activity is destroyed by the time you reach this statement, your Context will automatically become null and you can handle the scenario.

Upvotes: 1

Jaiprakash Soni
Jaiprakash Soni

Reputation: 4112

Try

if (!isFinishing()) {
    gender.setText(values[0]);
}

Upvotes: 4

Lalit Poptani
Lalit Poptani

Reputation: 67286

I will insist that you that if you Activity is not running why don't you cancel the AsyncTask? That would be a better and feasible solution. If you Application is running say you move from one Activity to another then it won't give error AFAIK.

But, I would insist to cancel the AsyncTask then you'r Activity is not running, you can check AsyncTask is running or not,

if(task != null && task.equals(AsyncTask.Status.RUNNING))
task.cancel(true);

Upvotes: 1

uvesten
uvesten

Reputation: 3365

Shouldn't 

if (gender) {
   gender.setText(values[0]);
}

be enough?

Upvotes: 0

Related Questions