CODEWITHSUNDEEP
backupnsismove
Thalia
Thalia

Reputation: 14605

NSIS doesn't backup all files

An NSIS installer creates a fairly large folder structure. When the installer starts, it checks the registry to see if there is a current version installed...

Then it asks if you want to make a backup of the current folder.

It works most of the time, but sometimes when it is backing up older versions, instead of copying over the entire directory, it only copies the icon.

!insertmacro un.MoveFolder "$INSTDIR" "${BACKUP_FOLDER}" "*.*"

Reference: http://nsis.sourceforge.net/MoveFileFolder 

!insertmacro MoveFolder "$INSTDIR\[path\]source-folder[\]" "$INSTDIR\[path\]destination-folder[\]" "file-mask"

Afterwards, it moves on to the delete section...

Could it be that it doesn't have time to do it ? it starts the next process before finishing the move ?

What else could be going on so that it does not copy the entire folder ?

During the installer, I see 

Create folder c:\backup_folder
Moving files: c:\current_folder\*.* to c:\backup_folder\
Delete file: c:\current_folder\file1.........

And at the end, backup_folder has only the icon (not all the files)

Edit: The solution - please see my post here NSIS difficulty moving folders - $INSTDIR is indeed a special folder so I had to move the uninstaller to a $TEMP folder.

Upvotes: 1

Views: 937

Answers (1)

Anders
Anders

Reputation: 101569

Is there any reason why you cannot use the built-in CopyFiles command?

To debug this I would suggest that you add a DetailPrint near the top of the .MoveFolder_Locate_moveFile function. If you see all the file names go by then the problem is the move operation in that function, if not then the problem is in the ${Locate} macro used by this code.

Another alternative is to watch the filesystem operations with Process Monitor...

Upvotes: 1

Related Questions