CODEWITHSUNDEEP
graphicsgraphd3.jsforce-layout
NullVoxPopuli
NullVoxPopuli

Reputation: 65103

d3.js: "Cannot read property 'weight' of undefined" when manually defining both nodes and links for force layout

I tried setting both nodes and links at the same time this way:

var force = d3.layout.force()
    .size([w, h])
    .nodes(nodes)
    .links(connections)
    .start();

nodes = [{"name":"data_base_id", "kind":"subgenre"},...]
connections = [{"source":"name_of_node", "target":"name_of_other_node"},...]

I have data that may not have connections, so it is necessary to defined the nodes, so that all of the nodes get rendered. And defining the genres is pretty easy. but I get this error;

Cannot read property 'weight' of undefined

And when I comment out .links(connections) the graph renders (juts a bunch of dots scattered throughout...) How do I get the connections / links to cooperate with d3?

I was reading the docs, and apparently the source and target have to be INDEXES of the nodes in the nodes array. Is there anyway to change that? So, I can use the name of a node rather than the index it has in an array?

Upvotes: 20

Views: 20315

Answers (6)

ptim
ptim

Reputation: 15587

Thanks to the answers above which refer to null source or target values!

I've been testing out the graph from http://bl.ocks.org/mbostock/4062045, and found that my data referenced a missing node.

This may help others debug this issue:

d3.json("my-buggy-data.json", function(error, graph) {

    // Find blank links, which give the error
    // "Uncaught TypeError: Cannot read property 'weight' of undefined"
    graph.links.forEach(function(link, index, list) {
        if (typeof graph.nodes[link.source] === 'undefined') {
            console.log('undefined source', link);
        }
        if (typeof graph.nodes[link.target] === 'undefined') {
            console.log('undefined target', link);
        }
    });

    force
        .nodes(graph.nodes)
        .links(graph.links)
        .start();

Upvotes: 10

elachell
elachell

Reputation: 2677

In addition to the answers mentioning the null in the source/target of links, the reason for this could be the assignment of an out-of-range source/target. E.g. you have 10 nodes and you assign the target to be the 11-th indexed node.

Upvotes: 12

Ells
Ells

Reputation: 83

I've had this issue pop up in a number of ways. Most recently, I had my edge list as follows:

{Source: 0; Target: 1}

instead of:

{source: 0, target: 1}

Upvotes: 2

air_bob
air_bob

Reputation: 1337

I encounter same problem before, it is due to there is null values in source/target of links. print out nodes and links information might help to debug

Upvotes: 19

synaptikon
synaptikon

Reputation: 699

I think you might have null values in your source and target. I had this bug too and fixed it by filtering out the null values.

Upvotes: 5

ZachB
ZachB

Reputation: 15366

The force-directed layout uses edge weights to calculate the layout. Try adding a dummy "weight":1 to all of your connections.

The code that initializes the links looks like this:

links.forEach(function(d) {
    if (typeof d.source == "number") { d.source = nodes[d.source]; }
    if (typeof d.target == "number") { d.target = nodes[d.target]; }
});

Presumably you could tweak that (in the d3 source) to use any property/type.

Upvotes: 12

Related Questions