CODEWITHSUNDEEP
phpsqlmysql
Kevin
Kevin

Reputation: 23634

Error in SQL UPDATE query

$result = mysql_query("UPDATE categories
        SET cd_title='$docuTitle' , cd_link='$linkTitle'
        WHERE c_name='$catID'");

What is wrong with this update query?

Upvotes: 0

Views: 133

Answers (3)

superUntitled
superUntitled

Reputation: 22527

If your data is sanitized, remove the single quotes from around the php variables.

Upvotes: 0

Quentin
Quentin

Reputation: 943100

There is probably something wrong with the data in your variables — but we can't see what they contain.

You should be using parameterized queries, which would deal with any odd characters in your data that might mess up the statement.

See How can I prevent SQL injection in PHP? and When are the most recommended times to use mysql_real_escape_string()

Upvotes: 2

Blixt
Blixt

Reputation: 50149

I would change the query to this, to avoid errors if input contains apostrophes:

$result = mysql_query(
    "UPDATE categories SET
         cd_title='" . mysql_real_escape_string($docuTitle) . "',
         cd_link='" . mysql_real_escape_string($linkTitle) . "'
     WHERE
         c_name='" . mysql_real_escape_string($catID) . "'");

Upvotes: 0

Related Questions