CODEWITHSUNDEEP
javajunitfileinputstream
Bertram Nudelbach
Bertram Nudelbach

Reputation: 1841

How to test that FileInputStream has been closed?

how can I write a JUnit test, that checks if a FileInputStream has been closed?

Consider the following code,

import java.io.FileInputStream;

class FileInputStreamDemo {

  public static void main(String args[]) throws Exception {
    FileInputStream fis = new FileInputStream(args[0]);

    // Read and display data
    int i;
    while ((i = fis.read()) != -1) {
      System.out.println(i);
    }

    fis.close();

  }
}

I would like to write a test like this:

@Test
public void test() {
  FileInputStreamDemo.main("file.txt");
  // test here, if input stream to file is closed correctly
}

Although this code example doesn't make much sense, I would like to now how to write a JUnit test that checks if the FIS has been closed. (If possible: without even having a reference to the original FIS object)

Upvotes: 4

Views: 2940

Answers (1)

Sarel Botha
Sarel Botha

Reputation: 12700

You should create a separate class called MyFileReader which does the job of reading the file. You then create a class MyFileReaderTest which instantiates your new class and calls the methods in it to test that it behaves correctly. If you make fis a protected member of the MyFileReader class the test can access fis and verify it has been closed.

Instead of using FileInputStream you should use an interface like InputStream so that you can create a MockInputStream which doesn't really create a file but keeps track of whether close() was called on it. Then you can test for that in your test code.

Upvotes: 4

Related Questions