CODEWITHSUNDEEP
androidandroid-listview
MrYanDao
MrYanDao

Reputation: 1263

Adding Array in SQLite While Loop

I am using this -> http://www.ezzylearning.com/tutorial.aspx?tid=1763429 to create my own custom listview.

For my project, I am using while loop to get data and getting data back.

The original code is :

DownloadClass data[] = new DownloadClass[] { 
    new DownloadClass("test", "test"), 
    new DownloadClass("test", "Sunny")
};

However for my case..

DownloadClass data[] = new DownloadClass[] {};
SQLFunctions entry = new SQLFunctions(this);
entry.open();
highestID = entry.getHighestId();
for (int l = 1; l < highestID; l++) {
    Long longVal  = Long.valueOf(l);
    new DownloadClass(entry.getName(longVal).toString(), entry.getURL(longVal).toString());
}

The listview appears to be empty because I know the data is not inserted. Any help is appreciated. Thanks.

EDIT : my DownloadClass :

public class DownloadClass {
        public String name;
        public String url;
        public DownloadClass(){
            super();
        }

        public DownloadClass(String name, String url) {
            super();
            this.name = name;
            this.url = url;
        }
    }

My new Activity

DownloadClass data[] = new DownloadClass[]; // need to work on this
    SQLFunctions entry = new SQLFunctions(this);
    entry.open();
    highestID = entry.getHighestId();
    Log.e("HIGHEST ID", highestID.toString());
    if (highestID > 1) {
    for (int l = 0; l < highestID; l++) {
        Long longVal = Long.valueOf(l);
        //String name = entry.getName(longVal);
        //String id = entry.getURL(longVal);
        //Log.e("NAME", name + " - " + id);
data[l] = new DownloadClass(entry.getName(longVal).toString(),entry.getURL(longVal).toString());
        }
    }
entry.close();

Upvotes: 0

Views: 347

Answers (2)

user370305
user370305

Reputation: 109257

Try this and let me know what happen..

DownloadClass data[]; 
SQLFunctions entry = new SQLFunctions(this);
entry.open();
highestID = entry.getHighestId();
data[] = new DownloadClass[highestID];
for (int l = 0; l < highestID; l++) {
Long longVal  = Long.valueOf(l);
data[i] = new DownloadClass(entry.getName(longVal).toString(), entry.getURL(longVal).toString());
}

Also start your loop with 0 index.. instead of 1..

Update:

First of all you are dynamically creating array of object. SO you have to know the size of array.

Second your loop is start with index 1, it should be 0.

Upvotes: 0

Rob Wagner
Rob Wagner

Reputation: 4421

You're not ever adding your new DownloadClass object to your array. You also need to allocate size if you're going to use an array instead of an ArrayList (which to be honest is probably what you want).

As you iterate through the loop you need to assign the new object to a position in the array.

data[i] = new DownloadClass(...);

Upvotes: 1

Related Questions