CODEWITHSUNDEEP
androidandroid-contentproviderandroid-contentresolver
Frank Sposaro
Frank Sposaro

Reputation: 8531

Batch Delete items with Content Provider in Android

I'm trying to batch delete some items in a table.

    String ids = { "1", "2", "3" };

    mContentResolver.delete(uri, MyTables._ID + "=?", ids);

However I keep getting this following error

java.lang.IllegalArgumentException: Too many bind arguments. 3 arguments were provided but the statement needs 1 arguments.

Upvotes: 9

Views: 6357

Answers (3)

Pawan Chaurasiya
Pawan Chaurasiya

Reputation: 901

String sqlCommand = String.format("DELETE FROM %s WHERE %s IN (%s);", TABLE_NAME, KEY_ID, 1,2,3);

db.execSQL(sqlCommand);

Upvotes: 0

X.Y.
X.Y.

Reputation: 13916

You can use ContentProviderOperation for batch deletion/insertion/update in one transaction. It's much nicer you don't have to concatenate strings. It also should be very efficient. For deletion:

    ArrayList<ContentProviderOperation> operations = new ArrayList<ContentProviderOperation>();
    ContentProviderOperation operation;

    for (Item item : items) {

        operation = ContentProviderOperation
                .newDelete(ItemsColumns.CONTENT_URI)
                .withSelection(ItemsColumns.UID + " = ?", new String[]{item.getUid()})
                .build();

        operations.add(operation);
    }

    try {
        contentResolver.applyBatch(Contract.AUTHORITY, operations);
    } catch (RemoteException e) {

    } catch (OperationApplicationException e) {

    }

Upvotes: 21

Jan-Henk
Jan-Henk

Reputation: 4874

The error occurs because you have a single placeholder (?) in your where clause, while you pass three arguments. You should do:

String ids = { "1", "2", "3" };

mContentResolver.delete(uri, MyTables._ID + "=? OR " + MyTables._ID + "=? OR " + MyTables._ID + "=?", ids);

I do not know if SQLite supports the IN clause, if so you could also do:

String ids = { "1, 2, 3" };

mContentResolver.delete(uri, MyTables._ID + " IN (?)", ids);

Upvotes: 10

Related Questions