rball
rball

Reputation: 6955

Why can't I get signalr to work with autofac dependency injection?

I'm new to AutoFac, but I thought this would be pretty straight forward. I've got a simple Hub:

public class Chat : Hub
{
    private readonly IHomeTasks _homeTasks;
    public Chat(IHomeTasks homeTasks) 
    {
        _homeTasks = homeTasks;
    }

    public void Send(string text)
    {
        _homeTasks.DoNothing();
        Clients.addMessage(text);
        var user = new UserDocument { Username = text };
    }
}

In my Global.ascx.cs I have:

    protected void Application_Start()
    {
        var builder = new ContainerBuilder();
        builder.RegisterControllers(typeof(MvcApplication).Assembly);
        builder.RegisterAssemblyTypes(Assembly.GetExecutingAssembly()).AsImplementedInterfaces();

        builder.RegisterType<Helpers.AutofacDependencyResolver>().As<SignalR.IDependencyResolver>(); // Not sure if I need this or...

        var container = builder.Build();
        RouteTable.Routes.MapHubs(new Helpers.AutofacDependencyResolver(container));
        DependencyResolver.SetResolver(new AutofacDependencyResolver(container));

        AreaRegistration.RegisterAllAreas();
        RegisterGlobalFilters(GlobalFilters.Filters);
        RegisterRoutes(RouteTable.Routes);
    }

and my AutofacDependencyResolver I just copied from here:

public class AutofacDependencyResolver : DefaultDependencyResolver, IRegistrationSource
{
    private readonly ILifetimeScope _lifetimeScope;

    public AutofacDependencyResolver(ILifetimeScope lifetimeScope)
    {
        _lifetimeScope = lifetimeScope;
        _lifetimeScope.ComponentRegistry.AddRegistrationSource(this);
    }

    public override object GetService(Type serviceType)
    {
        object result;
        if (_lifetimeScope.TryResolve(serviceType, out result))
        {
            return result;
        }

        return null;
    }

    public override IEnumerable<object> GetServices(Type serviceType)
    {
        object result;
        if (_lifetimeScope.TryResolve(typeof(IEnumerable<>).MakeGenericType(serviceType), out result))
        {
            return (IEnumerable<object>)result;
        }

        return Enumerable.Empty<object>();
    }

    public IEnumerable<IComponentRegistration> RegistrationsFor(Service service, Func<Service, IEnumerable<IComponentRegistration>> registrationAccessor)
    {
        var typedService = service as TypedService;
        if (typedService != null)
        {
            var instance = base.GetServices(typedService.ServiceType);

            if (instance != null)
            {

                return instance.Select(i => RegistrationBuilder.ForDelegate(i.GetType(), (c, p) => i).As(typedService.ServiceType)
                    .InstancePerMatchingLifetimeScope(_lifetimeScope.Tag)
                    .CreateRegistration());
            }
        }

        return Enumerable.Empty<IComponentRegistration>();
    }

    bool IRegistrationSource.IsAdapterForIndividualComponents
    {
        get { return false; }
    }
}

My HomeTasks looks like this:

public class HomeTasks : Sandbox.Tasks.IHomeTasks
{
    public void DoNothing()
    {
    }
}

Doesn't look like anything is happening as I'm getting a error like this inside my SignalR.Hosting.AspNet.HttpTaskAsyncHandler:

Could not load type 'SignalR.Hosting.IRequest' from assembly 'SignalR, Version=0.5.1.10625, Culture=neutral, PublicKeyToken=null'.

Edit:

I removed all SignalR dll's and then re-added due to dfowler's answer and everything comes up great but now when I actually invoke the Send(text) on my Chat Hub I get this:

[MissingMethodException: No parameterless constructor defined for this object.]
   System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandleInternal& ctor, Boolean& bNeedSecurityCheck) +0
   System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean skipCheckThis, Boolean fillCache) +98
   System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean skipVisibilityChecks, Boolean skipCheckThis, Boolean fillCache) +241
   System.Activator.CreateInstance(Type type, Boolean nonPublic) +69
   System.Activator.CreateInstance(Type type) +6
   SignalR.Hubs.DefaultHubActivator.Create(HubDescriptor descriptor) +141
   SignalR.Hubs.DefaultHubManager.ResolveHub(String hubName) +71
   SignalR.Hubs.HubDispatcher.CreateHub(IRequest request, HubDescriptor descriptor, String connectionId, TrackingDictionary state, Boolean throwIfFailedToCreate) +679
   SignalR.Hubs.HubDispatcher.OnReceivedAsync(IRequest request, String connectionId, String data) +870
   SignalR.<>c__DisplayClass6.<ProcessRequestAsync>b__4(String data) +73
   SignalR.Transports.ForeverTransport.ProcessSendRequest() +141
   SignalR.Transports.ForeverTransport.ProcessRequestCore(ITransportConnection connection) +128
   SignalR.Transports.ForeverTransport.ProcessRequest(ITransportConnection connection) +37
   SignalR.PersistentConnection.ProcessRequestAsync(HostContext context) +1018
   SignalR.Hubs.HubDispatcher.ProcessRequestAsync(HostContext context) +216
   SignalR.Hosting.AspNet.AspNetHandler.ProcessRequestAsync(HttpContextBase context) +676
   SignalR.Hosting.AspNet.HttpTaskAsyncHandler.System.Web.IHttpAsyncHandler.BeginProcessRequest(HttpContext context, AsyncCallback cb, Object extraData) +125
   System.Web.CallHandlerExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +8968180
   System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +184

I think I'm just missing one piece here I just can't figure out what the heck it is.

What leads me to thinking that the wiring for SignalR has problems is because I also have a simple controller that works fine.

public class HomeController : Controller
{
    private IHomeTasks _homeTasks;
    public HomeController(IHomeTasks homeTasks)
    {
        _homeTasks = homeTasks;
    }

    public ActionResult Index()
    {
        _homeTasks.DoNothing(); // No problems resolving HomeTasks!
    }

Update with answer

    protected void Application_Start()
    {
        var builder = new ContainerBuilder();
        builder.RegisterControllers(typeof(MvcApplication).Assembly);
        builder.RegisterAssemblyTypes(Assembly.GetExecutingAssembly()).AsImplementedInterfaces();
        builder.RegisterType<Chat>().InstancePerLifetimeScope();

        var container = builder.Build();

        DependencyResolver.SetResolver(new AutofacDependencyResolver(container));
        RouteTable.Routes.MapHubs(new AutofacSignalrDependencyResolver(container));

        AreaRegistration.RegisterAllAreas();

        RegisterGlobalFilters(GlobalFilters.Filters);
        RegisterRoutes(RouteTable.Routes);
    }

Got it to work with the above AppStart method. The key line being the builder.RegisterType().InstancePerLifetimeScope();. I honestly don't know if this is the best way as this was sort of a learning experience for me as I figured this out using what I knew better [Windsor] but figured I had spent enough time that I wanted to at least see something from my labors. Hope this helps someone :D

Upvotes: 1

Views: 1772

Answers (1)

davidfowl
davidfowl

Reputation: 38764

It Looks like a version mismatch, that's probably why it can't load the type. Make sure you are using binary compatible versions of your dependencies.

Upvotes: 2

Related Questions