Java Questions
Java Questions

Reputation: 7953

facing comparision issue in javascript

this is what is my java script function :

function issueOrReturn() {
    var functiontype = document.getElementById("functiontype").value;
    alert("functiontype : "+functiontype);
    if (functiontype=="issueTempcard") {
        alert("1111111111111111111111111");
        var empid = document.getElementById("empid").value;
        var tempcardnumber = document.getElementById("tempcardnumber").value;
        var dateofissue = document.getElementById("dateofissue").value;
        if(empid.length==0) {
            alert("Please enter Employee ID ");
            return false;
        }
        if(tempcardnumber.length==0) {
            alert("Please enter Card Number ");
            return false;
        }
        if(dateofissue.length==0) {
            alert("Please enter Date of issue ");
            return false;
        }
        if(empid.length > 0 && tempcardnumber.length > 0 && dateofissue.length > 0) {
            document.forms["frmTempcard"].submit();
        } else {
            alert("Please enter Employee ID and and Card Number and Date of issue ");
            return false;
        }
    }
    if (functiontype == "returnTempCard") {
        alert("222222222222222222222222222222");
        var empid = document.getElementById("empid").value;
        var dateofreturn = document.getElementById("dateofreturn").value;

        if (empid.length == 0) {
            alert("Please enter Employee ID ");
            return false;
        }
        if (dateofreturn.length == 0) {
            alert("Please enter Date of return ");
            return false;
        }
        if (empid.length > 0 && dateofreturn.length > 0) {
            document.forms["frmTempcard"].submit(); 
        } else {
            alert("Please enter Employee ID and Date of return ");
            return false;
        }
    }
}

here the functiontype is : issueTempcard the alert is printed but it is not getting in the if loop of issueTempcard hence the form is not submitted,

also please advise me whether the following way is correct to submit the form :

if (empid.length > 0 && tempcardnumber.length > 0 && dateofissue.length > 0) {
    document.forms["frmTempcard"].submit(); 
} else {
    alert("Please enter Employee ID and and Card Number and Date of issue ");
}

kindly provide me some help so that i can do it.

Regards,

Upvotes: 0

Views: 58

Answers (1)

Timothy Groote
Timothy Groote

Reputation: 8653

Both your function definitions miss their closing } character. Because of this, they are not executed (because the javascript interpreter fails to read your entire function)

This JsFiddle shows your code up and running without a hitch. All i did is add the }

To help you debug your JS code, try using Firebug, which can show you where you went wrong ;)

Your way of submitting forms looks fine to me, but is also missing the trailing }

Upvotes: 1

Related Questions