dimba
dimba

Reputation: 27641

Declare array size in header file without #define's

I have a code a following (simplified version):

#define MESSAGE_SIZE_MAX 1024
#defined MESSAGE_COUNT_MAX 20

class MyClass {
public:
   .. some stuff
private:
   unsigned char m_messageStorage[MESSAGE_COUNT_MAX*MESSAGE_SIZE_MAX];
};

I don't like defines, which are visible to all users of MyCalss.

How can I do it in C++ style?

Thanks Dima

Upvotes: 2

Views: 3518

Answers (2)

avakar
avakar

Reputation: 32685

Why don't you simply use a constant?

const int message_size_max = 1024;

Note that unlike C, C++ makes constant variables in global scope have static linkage by default.

The constant variable above is a constant expression and as such can be used to specify array sizes.

char message[message_size_max];

Upvotes: 7

nik
nik

Reputation: 13468

The trick to get such things into the class definition is,

// public:
enum {MESSAGE_SIZE_MAX=1024, MESSAGE_COUNT_MAX=20};

I never liked #defines to be used like constants.
Its always a good practice to use enum.

Upvotes: 6

Related Questions