CODEWITHSUNDEEP
javascriptonclicksyntax-error
melo
melo

Reputation: 93

onclick="doSomething([object Object])" Uncaught SyntaxError: Unexpected identifier

var params = {a:1,b:2}; var str = '<a href="#" onclick="doSomething('+params+')">aaaa</a>'; document.write(str);

when I click the <a> on the page,it throws "Uncaught SyntaxError: Unexpected identifier".I can't understand.

Upvotes: 8

Views: 16565

Answers (6)

Rohit Sunil Nale
Rohit Sunil Nale

Reputation: 11

<button class="btn btn-primary" onclick='setInputForUpdate(${JSON.stringify(data)})' data-bs-toggle="modal"

Upvotes: 0

Abhishek Sinha
Abhishek Sinha

Reputation: 1219

Ran into same issue. Reason for the issue: params is converted to string 'object Object' when html is rendered.

The problem can be sorted out in two ways:

Approach 1: add a click handler to the js code. Refer add click handler

Approach 2: Say I want to pass a JSON object named 'params' to the onclick function. As I need a very few attributes of the 'params' object, instead of adding a new handler as in 1st approach, I would rather just pass those specific parameters as below:

'<a href="#" onclick="doSomething(\'' + params['attribute1'] + '\'\, \'' +params['attribute2'] + '\'\)">aaa</a>'

Upvotes: 0

Li0liQ
Li0liQ

Reputation: 11264

The reason is that when you use string concatenation, params is casted to string, as result you get something like [object Object] in parenthesis.

You should better put params as var params = '{a:1,b:2}';.

Upd.
As suggested in comments, another viable approach is using JSON.stringify:

var params = {a:1,b:2};
var str = '<a href="#" onclick="doSomething('
    + JSON.stringify(params)
    + ')">aaaa</a>';
document.write(str);

Please, pay attention that JSON.stringify may not be supported by older browsers and you'll need to include additional libraries to make them work.

Upvotes: 13

JDGuide
JDGuide

Reputation: 6525

The answer by Li0liQ is quite Ok. When you clicking on that link you can find doSomething[object Object]

This is only object required .You are not writing the params into document. Casting Problem.

Upvotes: 0

bertl
bertl

Reputation: 2094

The in your case str looks like this: <a href="#" onclick="doSomething([object Object])">aaaa</a>

As you can see, that is not what you want.

Upvotes: 0

Matt Lo
Matt Lo

Reputation: 5741

[object Object] is the string representation of any JavaScript object. In your scenario you have params concatenated with a string, which will cast any variable type to a string.

Upvotes: 1

Related Questions