CODEWITHSUNDEEP
springspring-mvc
Matthew Cachia
Matthew Cachia

Reputation: 4702

Handling Multiple forms of the same type - impossible?

Consider the following scenario:

  1. My form model

    public class PersonForm {
    @NotNull
    private String name;

    /*usual getters and setters*/
}

  2. My controller:

    @Controller
@SessionAttribute(types={ PersonForm.class })
public class MyController {

    @RequestAttribute(...)
    public String render(final ModelMap map) {
        /* get list of info and for each info 
         * create a PersonForm and put it in the modelmap
         * under key p0, p1, p2, ..., pn
         */
    }

    public String submit(final ModelMap map,
                         @Valid final PersonForm form,
                         final BindingResult result) {

        if (result.hasErrors()) {
            // return to page
        } else {
            // do necessary logic and proceed to next page
        }
    }
}

  3. And finally my JSP view

    ...
<c:forEach ...>
    <form:form commandName="p${counter}">
        ... other form:elements and submit button goes here
    </form:form>
</c:forEach>
...

As you can see I am trying to handle multiple forms of the same class type. The submit works -- it gets me to the submit(...) method just fine, and so does the validation. However re-rendering the page does not show me the expected error messages!

Even worse -- I checked what is being passed in the submit header and there is no indication whatsoever which form submitted, so there is no way to discriminate between one form on another. This led me to believe multiple forms of the same class type is not possible ...

Is there any other way I could do this (apart from Ajax) ?

Many thanks.

Upvotes: 2

Views: 533

Answers (2)

Matthew Cachia
Matthew Cachia

Reputation: 4702

I managed to get this 'hack' to work. It is as what jelies has recommended so the credit goes all to him.

In simple terms, the concept is to pre-fill your view using the traditional <c:forEach> construct. The tricky part is whenever the 'Submit' button of that respective row is pressed, all of the information must be injected into a hidden form and force-submitted to the Controller. If the screen is rendered again with some errors, the script must be responsible of injecting the values back to the respective rows including the errors.

1) My model

    public class PersonForm {

        private String id;

        @NotNull
        private String name;

        /*usual getters and setters*/
    }

2) My controller

    @Controller
    @SessionAttribute(/* the hidden form name, the person list */)
    public class MyController {

        @RequestAttribute(...)
        public String render(final ModelMap map) {
            /* get list of info and for each info 
             * create a PersonForm and put it in the modelmap
             * under key p0, p1, p2, ..., pn
             */
        }

        public String submit(final ModelMap map,
                             @Valid final PersonForm form,
                             final BindingResult result) {

            if (result.hasErrors()) {
                // return to page
            } else {
                // do necessary logic and proceed to next page
            }
        }
    }

3) My view

    ...

    <form:form commandName="personForm" cssStyle="display: none;">
        <form:hidden path="id"/>
        <form:hidden path="name" />
        <form:errors path="name" cssStyle="display: none;" />
    </form:form>

    ...

    <c:forEach var="p" items="${pList}">
        <input type="text" id="${ p.id }Name" value="${ p.name }" />
        <!-- to be filled in IF the hidden form returns an error for 'name' -->
        <span id="${ p.id }nameErrorSpan"></span>
        <button type="button" value="Submit" onclick="injectValuesAndForceSubmit('${ p.id }');" />
    </c:forEach>

    ...

    <script type="text/javascript">

    injectValuesAndForceSubmit = function(id) {

        $('#id').val( id ); // fill in the hidden form's id
        $('#name').val( $('#'+id+'name').val() ); //fill in the hidden form's name

        $('#personForm').submit(); //submit!
    }



    $(document).ready(function() {

        var id = $('#id').val();    
        if (id.trim().length == 0) {
            //Empty. Nothing to do here as this is a simple render.
        } else {

            //The page seems to be returning from some sort of error ... pre-fill the respective row!
            $('#'+id+'name').val($('#name').val());
            var hiddenNameErrorSpan = $('#name.errors');
            if (hiddenNameErrorSpan) {
                $('#'+id+'nameErrorSpan').text(hiddenNameErrorSpan.html());
            }
        } //else
    }
    </script>

As you can see the view has the hairiest parts -- hopefully it will still proves to be useful for anyone who (unfortunately) comes across the same situation as mine. Cheers!

Upvotes: 2

jelies
jelies

Reputation: 9290

IMHO having multiple forms makes things overcomplicated (or at least with spring). Also, you are using multiple forms but only one is going to be submitted.

So, I suggest that the easiest way to manage this is using a unique hidden external form with person properties. When one of the buttons is pressed, fill accordingly the person properties of form and submit it. With this you are achieving the tipical spring form submit/validation.

Maybe this solution requires a bit work with JavaScript, but I don't know how to handle spring-mvc with multiple forms, I always tried to avoid it, due to previous unsuccessful attemps.

Upvotes: 1

Related Questions