CODEWITHSUNDEEP
android
hellowill89
hellowill89

Reputation: 1578

Error: WebView.destroy() called while still attached

I am getting this error when the device changes orientation:

Error: WebView.destroy() called while still attached

With this code:

protected void onDestroy()
{
    if (adView != null)
    {
        adView.destroy();
    }
}

What is the reason for this? How do I avoid this error?

Upvotes: 36

Views: 43946

Answers (5)

Édouard Mercier
Édouard Mercier

Reputation: 495

According to my tests, this issue is revealed in AdMob SDK v6.4.1 and at least on Android v4.2.2+. When testing the AdMob sample application referred to at https://developers.google.com/mobile-ads-sdk/docs/admob/fundamentals#android (direct link is http://google-mobile-dev.googlecode.com/files/Android_XML.zip), the issue occurs when closing the sample screen.

My work-around is rather:

 @Override
  public void onDestroy()
  {
    // Destroy the AdView.
    if (adView != null)
    {
      final ViewGroup viewGroup = (ViewGroup) adView.getParent();
      if (viewGroup != null)
      {
        viewGroup.removeView(adView);
      }
      adView.destroy();
    }

    super.onDestroy();
  }

Hope that helps other people, and that the AdMob will very soon fix that annoying issue.

Upvotes: 9

Meng
Meng

Reputation: 181

 @Override
public void onDetachedFromWindow() {
    super.onDetachedFromWindow();
    if (mWebView != null) {
        mWebView.destroy();
    }
}

Upvotes: 10

Klaus Villaca
Klaus Villaca

Reputation: 587

For you don't get this error you need to have a parent layout, e.g. : RelativeLayout and remove the WebView component, that might had been defined on you layoutWebView.xml.

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
        android:id="@+id/webviewRelativeLayout"
        android:layout_width="fill_parent"
        android:layout_height="fill_parent">

<WebView
    android:id="@+id/webView1"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:layout_below="@+id/headerAlarmsWebViewTxt"
    android:layout_marginBottom="0dip"
    android:hapticFeedbackEnabled="true"
    android:overScrollMode="never"
    android:scrollbarAlwaysDrawVerticalTrack="false"
    android:scrollbars="none" />

 </RelativeLayout>

Then you assign it to an instance variable e.g. :

_layout = (RelativeLayout) findViewById(R.id.webviewRelativeLayout);
webView = (WebView) findViewById(R.id.webView1);

and on Destroy do something like this:

@Override
protected void onDestroy() {
    super.onDestroy();
    _layout.removeView(webView);
    webView.setFocusable(true);
    webView.removeAllViews();
    webView.clearHistory();
    webView.destroy();
}

Upvotes: 7

user1668939
user1668939

Reputation: 564

You first need to detach the Webview:

webViewPlaceholder.removeView(myWebView);
myWebView.removeAllViews();
myWebView.destroy();

That did it for me.

Upvotes: 54

Matthew
Matthew

Reputation: 3431

To avoid the error you just need to remove all views before you destroy the ad.

@Override
public void onDestroy()
{
    if (adView != null)
    {
        adView.removeAllViews();
        adView.destroy();
    }
    super.onDestroy();
}

Upvotes: 31

Related Questions