CODEWITHSUNDEEP
delphistringmemory-managementpointersfastmm
migajek
migajek

Reputation: 8614

Delphi - structures' strings not being freed [FastMM manager]

If I declare 

PSomeStruct = ^TSomeStruct;
TSomeStruct = record 
  s1 : string;
end;

and I run the following code: 

var
  p: PSomeStruct;
begin
  new(p);
  p^.s1:= 'something bla bla bla';
  dispose(p);

the FastMM 4 memory manager reports that there was a memory leak (type: string, data dump: "something bla bla bla"). However, if I do set the s1 string to empty before calling dispose it's OK.

The second way I found is to change from record type to class, then instead of new I'm creating the instance, and instead of dispose I'm calling instance.Free(). It works without manually cleaning the strings.

Is there a way to make Delphi automatically clean my strings when I call dispose?

Upvotes: 4

Views: 1195

Answers (2)

The_Fox
The_Fox

Reputation: 7062

Is FastMM the first unit used in your .dpr? Otherwise it could be finalized too early, reporting false memoryleaks.

And does this simplified codesample also generate the same memoryleak as when you use your JvSimpleXML? When it's not, there is probably more going on then you suspect.

In my opinion: when FastMM reports a memory leak, there is a memoryleak.

Upvotes: 1

Rob Kennedy
Rob Kennedy

Reputation: 163257

You are already doing the correct thing. If FastMM says that string has leaked, then FastMM is wrong, or it's reporting a different string from the one you think it is. The Dispose procedure releases strings from records.

In this particular case, there shouldn't have been any memory allocated for that string anyway. It's a string literal, so I'd expect the compiler to assign that literal; its reference count should be -1 and FastMM never should have seen it.

Upvotes: 1

Related Questions