CODEWITHSUNDEEP
pythonwindowssubprocesscommand-line-arguments
workmad3
workmad3

Reputation: 25727

Python subprocess issue with ampersands

I'm currently having a major issue with a python script. The script runs arbitrary commands through a handler to convert incorrect error reporting into correct error reporting.

The issue I'm having is getting the script to work correctly on windows with a command that contains ampersands in it's path. I've attempted quoting the command, escaping the ampersand with ^ and neither works. I'm now out of ideas. Any suggestions?

To clarify from current responses:

  1. I am using the subprocess module
  2. I am passing the command line + arguments in as a list
  3. The issue is with the path to the command itself, not any of the arguments
  4. I've tried quoting the command. It causes a [Error 123] The filename, directory name, or volume label syntax is incorrect error
  5. I'm using no shell argument (so shell=false)
  6. In case it matters, I'm grabbing a pipe to stderr for processing it, but ignoring stdout and stdin
  7. It is only for use on Windows currently, and works as expected in all other cases that I've tested so far.
  8. The command that is failing is:

p = subprocess.Popen(prog, stderr = subprocess.PIPE, bufsize=-1)

when the first element of the list 'prog' contains any ampersands. Quoting this first string does not work.

Upvotes: 6

Views: 7201

Answers (5)

rickyteng
rickyteng

Reputation: 1

I try a situation as following:

exe = 'C:/Program Files (x86)/VideoLAN/VLC/VLC.exe'
url = 'http://translate.google.com/translate_tts?tl=en&q=hello+world'
subprocess.Popen([exe, url.replace("&","^&")],shell=True)

This does work.

Upvotes: 0

S.Lott
S.Lott

Reputation: 392050

"escaping the ampersand with ^"

Are you sure ^ is an escape character to Windows? Shouldn't you use \?

Upvotes: 0

workmad3
workmad3

Reputation: 25727

To answer my own question:

Quoting the actual command when passing the parameters as a list doesn't work correctly (command is first item of list) so to solve the issue I turned the list into a space separated string and passed that into subprocess instead.

Better solutions still welcomed.

Upvotes: 0

Mez
Mez

Reputation: 24951

Try quoting the argument that contains the &

wget "http://foo.com/?bar=baz&baz=bar"

Is usually what has to be done in a Linux shell

Upvotes: 0

Armin Ronacher
Armin Ronacher

Reputation: 32563

Make sure you are using lists and no shell expansion:

subprocess.Popen(['command', 'argument1', 'argument2'], shell=False)

Upvotes: 8

Related Questions