CODEWITHSUNDEEP
java
user1285928
user1285928

Reputation: 1476

How to use subList()

I have a JSF page which displays list of Glassfish log files. I use lazy loading for pagination. I keep the list of the log files names into Java List.

private List<directoryListObj> dataList = new ArrayList<>();

dataList = dataList.subList(firstRow, lastRow);

And here is the problem. For example I have 35 files into the directory. When I do this 

dataList = dataList.subList(5, 15);

It works fine. But when I do this:

dataList = dataList.subList(30, 38);

I get error wrong index because I want to get index outside of the List. How I can for example return List elements from 30 to 35? I want if I want to get index from 30 to 40 but if there only 35 indexes to get only 5.

Upvotes: 90

Views: 171659

Answers (7)

PKS
PKS

Reputation: 763

Better to use Skip and limit because subList can cause index out of bound expection

Upvotes: 0

Tony
Tony

Reputation: 2451

For kotlin, you could use: myList.subList(min, max.coerceAtMost(myList.size)

Or in terms of the question above: myList.subList(30, 38.coerceAtMost(myList.size)

Upvotes: -1

hao
hao

Reputation: 739

Although it may be too late, I suggest using stream in Java 8 to avoid handling the out of boundry exception manually.

this code

dataList = dataList.stream().skip(30).limit(8).collect(Collectors.toList());

works same as

dataList = dataList.subList(30, 38);

and in case of out of index error, dataList will be empty list instead of throwing any exception.

Upvotes: 4

Stefan Haberl
Stefan Haberl

Reputation: 10539

You could use streams in Java 8. To always get 10 entries at the most, you could do:

dataList.stream().skip(5).limit(10).collect(Collectors.toList());
dataList.stream().skip(30).limit(10).collect(Collectors.toList());

Upvotes: 14

kosa
kosa

Reputation: 66637

Using subList(30, 38); will fail because max index 38 is not available in list, so its not possible.

Only way may be before asking for the sublist, you explicitly determine the max index using list size() method.

for example, check size, which returns 35, so call sublist(30, size());

OR

COPIED FROM pb2q comment

dataList = dataList.subList(30, 38 > dataList.size() ? dataList.size() : 38);

Upvotes: 107

Haroldo_OK
Haroldo_OK

Reputation: 7230

I've implemented and tested this one; it should cover most bases:

public static <T> List<T> safeSubList(List<T> list, int fromIndex, int toIndex) {
    int size = list.size();
    if (fromIndex >= size || toIndex <= 0 || fromIndex >= toIndex) {
        return Collections.emptyList();
    }

    fromIndex = Math.max(0, fromIndex);
    toIndex = Math.min(size, toIndex);

    return list.subList(fromIndex, toIndex);
}

Upvotes: 55

Joe K
Joe K

Reputation: 18424

To get the last element, simply use the size of the list as the second parameter. So for example, if you have 35 files, and you want the last five, you would do:

dataList.subList(30, 35);

A guaranteed safe way to do this is:

dataList.subList(Math.max(0, first), Math.min(dataList.size(), last) );

Upvotes: 43

Related Questions