CODEWITHSUNDEEP
javascriptjqueryinternet-explorerdom
Stephen Watkins
Stephen Watkins

Reputation: 25765

Why is element empty in IE after being removed from the DOM?

The following HTML and JavaScript is taken from parts of this jsFiddle: http://jsfiddle.net/stephenjwatkins/2j3ZB/3/

HTML:

<p class="source">
    Source
</p>
<div id="target">
    <p class="dummy">
        Target
    </p>
</div>
<button id="transfer-button">Transfer</button>

JavaScript:

var sourceEl = $('.source');
var targetEl = $('#target');

$('#transfer-button').click(function() {
    targetEl.html('<p class="dummy">Transferring...</p>');
    setTimeout(function() {
        // Source element will be empty on second attempt to append
        targetEl.html('').append(sourceEl);
    }, 750);
    return false;
});​

Note that the setTimeout and dummy text is there simply for a visual indicator.

As one can see, after the source element is appended and removed once from the DOM, IE (all versions) will add an empty element to the DOM upon any further appends; whereas, all other browsers will add the correct, non-empty element.

Another aspect that adds to the confusion is that the sourceEl still has element information (e.g. sourceEl.attr('class') will return "source").

I know of methods to mitigate the issue (e.g. sourceEl.clone()), but it would be nice to have a better understanding as to why IE is behaving differently to avoid any related problems in the future.

What is causing the source element to be uniquely empty in IE after once replacing the element?

Upvotes: 4

Views: 795

Answers (2)

Fabr&#237;cio Matt&#233;
Fabr&#237;cio Matt&#233;

Reputation: 70159

First let's highlight the important parts:

  1. (first click) Takes the source element and put it inside the target element;
  2. (second click) Empties the target element and appends a new child (p.dummy) to it, effectively removing source from the DOM;
  3. Empties the target element and tries to re-append source, which is no longer present in the DOM.

At first look, this wouldn't work in any browser as the source element has already been removed from the DOM. The "magic" here is JavaScript's Garbage Collector. Browsers see that sourceEl is still scoped (inside the setTimeout closure) and do not trash the referenced DOM element inside of the sourceEl jQuery object.

The issue here is not JScript (Microsft's Javascript implementation)'s Garbage Collector, but rather how JScript handles the DOM parsing when setting an element's innerHTML.

Other browsers will simply detach all childNodes (whose will be collected by GC when there are no more active references) and parse the passed html string into DOM elements appending them to the DOM. Jscript, on the other hard, will also erase the detached childNodes' innerHTML/childNodes. Check this fiddle for an illustration.

The element, in fact, does still exist in IE and is appended to the DOM:

enter image description here

It just has no childNodes anymore.

To prevent this kind of behavior, .clone() the element (as mentioned in the question) or .detach() it before calling .html() on its parent, if you intend to re-use the element instead of "overwriting" it.

Here's a fiddle using .detach() before the element is overwritten, works fine in all browsers.

Upvotes: 7

Richard Rout
Richard Rout

Reputation: 1316

In my mind, IE is behaving correctly, and the other browsers are magical for working. It all stems from when you call the line:

targetEl.html('<p class="dummy">Transferring...</p>');

This removes the sourceEl element from the page. So it no longer exists. I guess other browsers are remembering the DOM object as there is still a variable referencing it. But IE recognizes this as no longer existing on the page, so it loses the reference.

As you mentioned, I would recommend cloning the object when you click. This creates a new object in JavaScript. Luckily, overwriting same variable works.

    sourceEl = sourceEl.clone();

http://jsfiddle.net/AbJQE/3/

edit You can also remove any possibly existing original source objects before you insert this new one. This fixes the problem for trigger happy clickers:

setTimeout(function() {
    $('.source').remove();
    targetEl.html('').append(sourceEl);
}, 750);

Upvotes: 2

Related Questions