CODEWITHSUNDEEP
model-view-controllercodeigniterview
user149052
user149052

Reputation: 81

What is the best practice for displaying multiple views in Codeigniter?

I'm trying to determine the best practice for calling multiple views from the same method in a controller.

Is it preferable in the controller to make one view call, then have that view call all the views it needs, or call all the views you need in sequence in the controller?

Example: 

function index(){
   //set all data variables
   //then send them to the view
   $this->load->view($index_view, $data);
}

or

function index(){
  //set variables
  //then call each view
  $this->load->view($header_view, $header_data);
  $this->load->view($body_view, $body_data);
  $this->load->view($footer_view, $footer_data);

The Codeigniter guide shows both ways, but does not seem to advise to the best practice...is there one?

Upvotes: 2

Views: 3382

Answers (5)

Nishant
Nishant

Reputation: 3694

This is expected behavior. Once variables are set they become available within the controller class and its view files. Sending an array in $this->load->view() is the same as sending an array directly to $this->load->vars() before calling the view file. This simplifies things for most people using multiple views in a controller. If you are using multiple view files in a single controller and want them to each have their own set of variables exclusively, you’ll need to manually clear out the $this->load->_ci_cached_vars array between view calls.

A code comment in the Loader class describes another situation showing why this is the desired default behavior:

  • You can either set variables using the dedicated $this->load_vars()
  • function or via the second parameter of this function. We'll merge
  • the two types and cache them so that views that are embedded within
  • other views can have access to these variables.

Upvotes: 0

jwpage
jwpage

Reputation: 546

I didn't like the way of including the header/footer within the view, and I didn't like loading the footer and header each time in every single Controller function.

To fix this, I extended the Controller class with my own view display function.

<?php
// in application/libraries/MY_Controller.php
class MY_Controller extends Controller {
    function _displayPage($page, $data = array()) {
        $this->view->load('header', $data);
        $this->view->load($page, $data);
        $this->view->load('footer', $data);
    }
}
?>

// in application/controllers/home.php
<?php
class Home extends MY_Controller {
    function index() {
        $this->_displayPage('home/index', array('title' => 'Home'));
    }
}
?>

Not sure if this is CodeIgniter "best practice" but it makes sense to me.

Upvotes: 9

stef
stef

Reputation: 27789

Agree with Christian Davén: its view / display logic not data or business / logic. essentially its the same as using php includes for snippets like navigation, footer etc. you're just embedding markup.

Upvotes: 0

Christian Dav&#233;n
Christian Dav&#233;n

Reputation: 18237

I would say that the controller should only display one view. Then it's up to the view if it wants to show a header, footer, sidebar or whatever. The controller shouldn't have to care, its job is to get data from a model and hand it to a view. Not decide if the view should have a header and a footer.

Upvotes: 1

MM.
MM.

Reputation: 2681

I don't think there is a definitive answer for that. Choose one and stick with it, it's important to be consistent.

Anyway, I'd prefer the second one.

Upvotes: 1

Related Questions