CODEWITHSUNDEEP
androidandroid-viewpagerandroid-mediaplayer
Erdem Azaklı
Erdem Azaklı

Reputation: 255

Play sound file on user events

I want to play a sound file with mediaplayer and viewpager, but it is not working. I get the error message 

"Unfortunately, the process horizontalviewpaging has stopped"

(Page swiping and on click button events) How can I solve this issue?

package ro.ovidiuconeac.horizontalviewswiping;

import ro.ovidiuconeac.horizontalviewswiping.R;
import android.app.Activity;
import android.media.MediaPlayer;
import android.os.Bundle;
import android.support.v4.view.ViewPager.OnPageChangeListener;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.Toast;

public class CustomPageChangeListener extends Activity implements OnPageChangeListener, OnClickListener {

  private MediaPlayer soundplay = null;

  @SuppressWarnings("unused")
  public void onCreate(Bundle savedInstanceState) {

    // load layout
    super.onCreate(savedInstanceState);
    setContentView(R.layout.page_1);
    MediaPlayer soundplay=MediaPlayer.create(this, R.raw.catsound); 
  }

  private Button buttonBlue   = null;
  private Button buttonYellow = null;
  private Button buttonRed    = null;
  private Activity context    = null;

  /**
   * Constructor
   */   
  public CustomPageChangeListener(Activity context) {
    this.context = context;

  }

  public void onPageScrollStateChanged(int arg0) {
    // TODO Auto-generated method stub

  }

  public void onPageScrolled(int arg0, float arg1, int arg2) {
     // TODO Auto-generated method stub

  }

  public void onPageSelected(int position) {

    switch (position) {
      case 0 : {
        ButtonBlue = (Button) context.findViewById(R.id.buttonBlue);
        buttonBlue.setOnClickListener(this);
        soundplay.start();  
        break;
      }
      case 1 : {
        buttonYellow = (Button) context.findViewById(R.id.buttonYellow);
        buttonYellow.setOnClickListener(this);
        soundplay.start();  
        break;
      }
      case 2 : {
        buttonRed = (Button) context.findViewById(R.id.buttonRed);
        buttonRed.setOnClickListener(this);
        soundplay.start();  
        break;
      }
    }   
  }

  public void onClick(View v) {

    // Click button blue
    if (buttonBlue != null && v.getId() == buttonBlue.getId()) {
      Toast.makeText(context, "Blue screen", Toast.LENGTH_SHORT).show();
      soundplay.start();    
    }

    // Click button yellow
    if (buttonYellow != null && v.getId() == buttonYellow.getId()) {
      Toast.makeText(context, "Yellow screen", Toast.LENGTH_SHORT).show();
      soundplay.start();        
    }

    // Click button red
    if (buttonRed != null && v.getId() == buttonRed.getId()) {
      Toast.makeText(context, "Red screen", Toast.LENGTH_SHORT).show();
      soundplay.start();    
    }   
  }
}

Edited out of an 'answer' that was really extra information for this question.

> 09-01 08:38:04.964: E/AndroidRuntime(631): FATAL EXCEPTION: main
> 09-01 08:38:04.964: E/AndroidRuntime(631): java.lang.NullPointerException
> 09-01 08:38:04.964: E/AndroidRuntime(631): at android.content.ContextWrapper.getApplicationContext(ContextWrapper.java:101)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at ro.ovidiuconeac.horizontalviewswiping.CustomPageChangeListener.onClick(CustomPageChangeListener.java:80)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at android.view.View.performClick(View.java:4084)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at android.view.View$PerformClick.run(View.java:16966)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at android.os.Handler.handleCallback(Handler.java:615)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at android.os.Handler.dispatchMessage(Handler.java:92)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at android.os.Looper.loop(Looper.java:137)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at android.app.ActivityThread.main(ActivityThread.java:4745)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at java.lang.reflect.Method.invokeNative(Native Method)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at java.lang.reflect.Method.invoke(Method.java:511)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
> 09-01 08:38:04.964: E/AndroidRuntime(631): at dalvik.system.NativeStart.main(Native Method)

I changed code but not working.

package ro.ovidiuconeac.horizontalviewswiping;
import ro.ovidiuconeac.horizontalviewswiping.R;
import android.app.Activity;
import android.media.MediaPlayer;
import android.support.v4.view.ViewPager.OnPageChangeListener;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.Toast;

public class CustomPageChangeListener extends Activity implements OnPageChangeListener,     OnClickListener {

    MediaPlayer soundplay;
private Button buttonBlue   =   null;
private Button buttonYellow =   null;
private Button buttonRed    =   null;
private Activity context    =   null;

/**
 * Constructor
 */ 

public CustomPageChangeListener(Activity context) {
    this.context = context;

}

public void onPageScrollStateChanged(int arg0) {
    // TODO Auto-generated method stub

}

public void onPageScrolled(int arg0, float arg1, int arg2) {
    // TODO Auto-generated method stub

}

public void onPageSelected(int position) {

    switch (position) {
        case 0 : {
            buttonBlue = (Button)    context.findViewById(R.id.buttonBlue);
            buttonBlue.setOnClickListener(this);

            break;
        }
        case 1 : {
            buttonYellow = (Button) context.findViewById(R.id.buttonYellow);
            buttonYellow.setOnClickListener(this);
            break;
        }
        case 2 : {
            buttonRed = (Button) context.findViewById(R.id.buttonRed);
            buttonRed.setOnClickListener(this);

            break;
        }
    }   
}


public void onClick(View v) {

    // Click button blue
    if (buttonBlue != null && v.getId() == buttonBlue.getId()) {
        Toast.makeText(context, "Blue screen", Toast.LENGTH_SHORT).show();

    }

    // Click button yellow
    if (buttonYellow != null && v.getId() == buttonYellow.getId()) {

        //  Toast.makeText(context, "Yellow screen",   Toast.LENGTH_SHORT).show();
        playMusic();
    }

    // Click button red
    if (buttonRed != null && v.getId() == buttonRed.getId()) {
        Toast.makeText(context, "Red screen", Toast.LENGTH_SHORT).show();

    }   
}


public void playMusic () {
    soundplay = new MediaPlayer();
        try {   
        soundplay = MediaPlayer.create(getApplicationContext(), R.raw.bangyeni);
        soundplay.setVolume(1, 1);
        soundplay.start();

}
catch (Exception e){
    Toast.makeText(context, "Error", Toast.LENGTH_SHORT).show();
}   
}

}

Upvotes: 1

Views: 300

Answers (1)

WIllJBD
WIllJBD

Reputation: 6164

    private MediaPlayer soundplay = null;
@SuppressWarnings("unused")
public void onCreate(Bundle savedInstanceState) {
// load layout

super.onCreate(savedInstanceState);
setContentView(R.layout.page_1);
MediaPlayer soundplay=MediaPlayer.create(this, R.raw.catsound);

}

that code right there is likely the problem. You are trying to a play a null MediaPlayer. Please edit this line

     MediaPlayer soundplay=MediaPlayer.create(this, R.raw.catsound);

to look like this

    soundplay=MediaPlayer.create(this, R.raw.catsound);

The way you have it you are creating a second MediaPLayer soundplay with a smaller scope, that dies when the function ends, leaving the private MediaPLayer you set earlier as null.

also I think you are forgetting to cast in a new MediaPlayer object

     mp = new MediaPlayer();
     mp = MediaPlayer.create(getApplicationContext(), R.raw.sound);
     mp.setVolume(1, 1);
     mp.start();

that is the basic model I follow.

Upvotes: 1

Related Questions