CODEWITHSUNDEEP
javaspringspring-mvc
Brett Ryan
Brett Ryan

Reputation: 28255

Is it possible to have empty RequestParam values use the defaultValue?

if I have a a request mapping similar to the following:

@RequestMapping(value = "/test", method = RequestMethod.POST)
@ResponseBody
public void test(@RequestParam(value = "i", defaultValue = "10") int i) {
}

And then call this request with:

http://example.com/test?i=

I get the error message

Failed to convert value of type 'java.lang.String' to type 'int'; nested exception is java.lang.NumberFormatException: For input string: ""'

I can solve this by either stopping the javascript client from sending empty parameters, or by accepting string values and only parsing if they are not found to be blank.

UPDATE: Later versions of spring now implement the originally desired behaviour.

I've just tested this in spring 4.3.5 and have found that the behaviour will now in fact turn the null value into the default value without raising a NumberFormatException, thus; my original mapping now works fine.

I am not sure which version of spring this behavioural change was made.

Upvotes: 166

Views: 375282

Answers (6)

Abd Abughazaleh
Abd Abughazaleh

Reputation: 5535

You can use @Nullable with default value.

@Nullable @RequestParam(value = "i", defaultValue = "10") Integer i

Upvotes: 5

eis
eis

Reputation: 53462

This was considered a bug in 2013: https://jira.spring.io/browse/SPR-10180

and was fixed with version 3.2.2. Problem shouldn't occur in any versions after that and your code should work just fine.

Upvotes: 2

Matt
Matt

Reputation: 3525

You could change the @RequestParam type to an Integer and make it not required. This would allow your request to succeed, but it would then be null. You could explicitly set it to your default value in the controller method:

@RequestMapping(value = "/test", method = RequestMethod.POST)
@ResponseBody
public void test(@RequestParam(value = "i", required=false) Integer i) {
    if(i == null) {
        i = 10;
    }
    // ...
}

I have removed the defaultValue from the example above, but you may want to include it if you expect to receive requests where it isn't set at all: 

http://example.com/test

Upvotes: 225

Anand Tagore
Anand Tagore

Reputation: 692

You can set RequestParam, using generic class Integer instead of int, it will resolve your issue.

   @RequestParam(value= "i", defaultValue = "20") Integer i

Upvotes: 20

Tisha
Tisha

Reputation: 857

You can also do something like this - 

 @RequestParam(value= "i", defaultValue = "20") Optional<Integer> i

Upvotes: 2

AppLend
AppLend

Reputation: 1694

You can keep primitive type by setting default value, in the your case just add "required = false" property:

@RequestParam(value = "i", required = false, defaultValue = "10") int i

P.S. This page from Spring documentation might be useful: Annotation Type RequestParam

Upvotes: 131

Related Questions