CODEWITHSUNDEEP
iosuinavigationcontrolleruitabbarcontrollertitlebar
ghostrider
ghostrider

Reputation: 5259

Setting the title of a navigation bar inside a tab bar controller

Well in my app I have a navigation controller with a table view, and when pressing a button a tab controller opens. In its first tab, I want the title of the navigation bar to be set.

Here is an image of my storyboard just to make sure we undestand each other.

enter image description here

This is my code that supposed to be working. I had used this code, when trying to open a single view and not a tab controller and it was working properly. So I guess I must change something.

    - (void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath
{       
        SkiCenter *myDetViewCont = [[SkiCenter alloc] initWithNibName:@"SkiCenter" bundle:[NSBundle mainBundle]];
        myDetViewCont.ski_center = [centers objectAtIndex:indexPath.row];
        UIStoryboard * storyBoard = [UIStoryboard storyboardWithName:@"MainStoryboard" bundle:nil];
        [[self navigationController] pushViewController:[storyBoard instantiateViewControllerWithIdentifier:@"SkiCenterIds"] animated:YES];
        //[self.navigationController pushViewController:myDetViewCont animated:YES]; // "Pushing the controller on the screen"
        [myDetViewCont release]; // releasing controller from the memory
        myDetViewCont = nil;        
    }

Where Skicenter is the name of the class for my first tab and SkiCenterIds is the identifier of my tab controller in storyboard.

Code in Skicenter.m is:

- (void)viewDidLoad
{
    [super viewDidLoad];
    // Do any additional setup after loading the view from its nib.

    self.navigationItem.title = ski_center;        
}

but I do not see any title. So what I have done wrong? I have also tried this:

[self.navigationController setTitle:@"Live"];

or 

self.title=ski_center;

the ski_center has value because it is printed out normally in the NSLog.

Upvotes: 17

Views: 24152

Answers (9)

Tiisetso Tjabane
Tiisetso Tjabane

Reputation: 2106

I came across this and found a simpler solution. A new solution would be to change the navigation bar title from the landing view controllers like below

override func viewDidLoad() {
    super.viewDidLoad()
    navigationController?.navigationBar.topItem?.title = "title";
 }

Upvotes: 5

raed
raed

Reputation: 5075

In Swift 4 and above

self.tabBarController?.title = "Title"

Upvotes: 8

Jigar Thakkar
Jigar Thakkar

Reputation: 7582

In swift 3 

self.tabBarController?.navigationItem.title = "Your title goes here"

Upvotes: 6

Suraj K Thomas
Suraj K Thomas

Reputation: 5883

 UITabBarController *tabController = (UITabBarController *)self.parentViewController;

 tabController.navigationItem.title = @"ABC";

This is working for me

From some R&D on internet

You have to pass the navigationItem up the chain. The UINavigationController shows the navigationItem belonging to its topViewController which is UITabBarController. The UITabBarController shows the navigationItem titles in its tabs. So what you need to do is make sure that the tabBarController's navigationItem is it's selectedViewController's navigationItem

So to recap:

UINavigationController title = topViewController.navigationItem.title

UITabBarController tabTitle = selectedViewController.navigationItem.title

UIViewController title = navigationItem.title

Upvotes: 2

nithinreddy
nithinreddy

Reputation: 6197

Simple!

[self.tabBarController setTitle:@"Title"];

Upvotes: 39

Rip
Rip

Reputation: 191

Adding on to ghostrider's solution, in the mytabbarcontroller.m self.navigationItem.title didn't work for me. I have a NavigationController whose detail view is a TabController and this is what I have in my first tab implementation

self.navigationController.visibleViewController.title = ski_center;

Upvotes: 18

ghostrider
ghostrider

Reputation: 5259

Basically I don't know if you did't noticed but I got it work like this:

I assigned my tab bar Controller a new class.

I did the following:

add it to app delegate.h

@property (nonatomic,retain) NSString *center;

add it to mainmap.m

AppDelegate *delegate = (AppDelegate *)[[UIApplication sharedApplication] delegate];
    delegate.center=[centers objectAtIndex:indexPath.row];

and in mytabbarcontroller.m

  AppDelegate *delegate = (AppDelegate *)[[UIApplication sharedApplication] delegate];
    ski_center=delegate.center;

    self.navigationItem.title = ski_center;

Upvotes: 1

Wasim
Wasim

Reputation: 5113

Ok just so you know, it's very bad practice to put a UITabBarController inside a UINavigationController - Apple recommends for good UI design that you only should ever put a UINavigationController inside a UITabBarController and not the other way round. Either way, you should be able to change the title from the UITabBarController like this;

- (void)viewDidLoad
{
    [super viewDidLoad];
    // Do any additional setup after loading the view from its nib.

    [[self.navigationController.viewControllers objectAtIndex:0] setTitle:ski_center];        
}

That should work.

Upvotes: 6

Fab1n
Fab1n

Reputation: 2284

try this:

[self.navigationController setTitle:@"Live"];

Upvotes: 1

Related Questions