user84786
user84786

Reputation: 631

Java: Comparing two string arrays and removing elements that exist in both arrays

This is mainly a performance questions. I have a master list of all users existing in a String array AllUids. I also have a list of all end dated users existing in a String array EndUids.

I am working in Java and my goal is to remove any users that exist in the end dated array from the master list AllUids. I know PHP has a function called array_diff.

I was curious if Java has anything that will compare two arrays and remove elements that are similar in both. My objective is performance here which is why I asked about a built in function. I do not want to add any special packages.

I thought about writing a recursive function but it just seems like it will be inefficient. There are thousands of users in both lists. In order to exist in the end dated list, you must exist in the AllUids list, that is until removed.

Example:

String[] AllUids = {"Joe", "Tom", "Dan", "Bill", "Hector", "Ron"};

String[] EndUids = {"Dan", "Hector", "Ron"};

Functionality I am looking for:

String[] ActiveUids = AllUids.RemoveSimilar(EndUids);

ActiveUids would look like this:

{"Joe", "Tom", "Bill"}

Thank you all, Obviously I can come up with loops and such but I am not confident that it will be efficient. This is something that will run on production machines everyday.

Upvotes: 13

Views: 47257

Answers (7)

Aravindh
Aravindh

Reputation: 1

    String s1 = "a,b,c,d";
    String s2 = "x,y,z,a,b,c";
    Set<String> set1 = new HashSet<String>();
    Set<String> set2 = new HashSet<String>();

    Set<String> set11 = new HashSet<String>();

    String[] splitS1 = s1.split(",");
    String[] splitS2 = s2.split(",");

    for(String s3:splitS1){
        set1.add(s3);
        set11.add(s3);
    }

    for(String s4:splitS2){
        set2.add(s4);
    }
    set1.removeAll(set2);
    set2.removeAll(set11);
    set1.addAll(set2);
    System.out.println(set1);

Upvotes: 0

Bireshwar
Bireshwar

Reputation: 51

/*
 * To change this template, choose Tools | Templates
 * and open the template in the editor.
 */

/**
 *
 * @author Bireswhar
 */
import java.util.Collection;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;

public class Repeated {

    public static void main(String[] args) {
//        Collection listOne = new ArrayList(Arrays.asList("milan","dingo", "elpha", "hafil", "meat", "iga", "neeta.peeta"));
//        Collection listTwo = new ArrayList(Arrays.asList("hafil", "iga", "binga", "mike", "dingo"));
//
//        listOne.retainAll( listTwo );
//        System.out.println( listOne );

        String[] s1 = {"ram", "raju", "seetha"};
        String[] s2 = {"ram"};
        List<String> s1List = new ArrayList(Arrays.asList(s1));
        for (String s : s2) {
            if (s1List.contains(s)) {
                s1List.remove(s);
            } else {
                s1List.add(s);
            }
             System.out.println("intersect on " + s1List);
        }
    }
}

Upvotes: 5

Jonathan Holloway
Jonathan Holloway

Reputation: 63674

Commons Collections has a class called CollectionUtils and a static method called removeAll which takes an initial list and a list of thing to remove from that list:

Collection removeAll(Collection collection,
                     Collection remove)

That should do what you want provided you use lists of users rather than arrays. You can convert your array into a list very easily with Arrays.asList() so...

Collection ActiveUids = CollectionUtils.removeAll(Arrays.asList(AllUids), 
                                                  Arrays.asList(EndUids))

EDIT: I also did a bit of digging with this into Commons Collections and found the following solution with ListUtils in Commons Collections as well:

List diff = ListUtils.subtract(Arrays.asList(AllUids), Arrays.asList(EndUids));

Pretty neat...

Upvotes: 13

Michael Borgwardt
Michael Borgwardt

Reputation: 346327

Don't use arrays for this, use Collection and the removeAll() method. As for performance: unless you do something idiotic that leads to O(n^2) runtime, just forget about it. It's premature optimization, the useless/harmful kind. "thousands of users" is nothing, unless you're doing it thousands of times each second.

BTW, PHP "arrays" are in fact hash maps.

Upvotes: 3

Laurence Gonsalves
Laurence Gonsalves

Reputation: 143224

The easiest solution is probably to put all of the elements into a Set and then use removeAll. You can convert to a Set from an array like this:

Set<String> activeUids = new HashSet<String>(Arrays.asList(activeUidsArray));

though you should really try to avoid using arrays and favor collections.

Upvotes: 3

Samuel Carrijo
Samuel Carrijo

Reputation: 17939

You could put those strings into a Collection instead, and then use removeAll method.

Upvotes: 1

Jon Skeet
Jon Skeet

Reputation: 1501043

You can't "remove" elements from arrays. You can set them to null, but arrays are of fixed size.

You could use java.util.Set and removeAll to take one set away from another, but I'd prefer to use the Google Collections Library:

Set<String> allUids = Sets.newHashSet("Joe", "Tom", "Dan",
                                      "Bill", "Hector", "Ron");
Set<String> endUids = Sets.newHashSet("Dan", "Hector", "Ron");
Set<String> activeUids = Sets.difference(allUids, endUids);

That has a more functional feel to it.

Upvotes: 6

Related Questions