CODEWITHSUNDEEP
javascriptjsonnode.jswebsocketeval
auino
auino

Reputation: 1656

WebSocket on Node.js and share a message between all the connected clients

I've got a Node.js server with websocket module, installed through the following command:

npm install websocket

Starting from this guide, I decided to extend it sharing the sent messages between all the clients.

Here is my (simplified) server code:

#!/usr/bin/env node
var WebSocketServer = require('websocket').server;
var http = require('http');

var server = http.createServer(function(request, response) {
    console.log((new Date()) + ' Received request for ' + request.url);
    response.writeHead(404);
    response.end();
});
server.listen(8080, function() {
    console.log((new Date()) + ' Server is listening on port 8080');
});

wsServer = new WebSocketServer({
    httpServer: server,
    autoAcceptConnections: false
});

var connectedClientsCount = 0; // ADDED
var connectedClients = []; // ADDED

wsServer.on('request', function(request) {
    var connection = request.accept('echo-protocol', request.origin);
    connectedClientsCount++;
    connectedClients.push(connection);
    console.log((new Date()) + ' Connection accepted.');
    connection.on('message', function(message) {
        if (message.type === 'utf8') {
            console.log('Received Message: ' + message.utf8Data);
            for(c in connectedClients) // ADDED
                c.sendUTF(message.utf8Data); // ADDED
        }
        else if (message.type === 'binary') {
            console.log('Received Binary Message of ' + message.binaryData.length + ' bytes');
            connection.sendBytes(message.binaryData);
        }
    });
    connection.on('close', function(reasonCode, description) {
        // here I should delete the client...
        console.log((new Date()) + ' Peer ' + connection.remoteAddress + ' disconnected.');
    });
});

In this case I can get the connectedClientsCount value, but I can't manage the connectedClients list.

I also tried with ((eval)c).sendUTF(message.utf8Data); as for statement but it doesn't work.

Upvotes: 2

Views: 5975

Answers (2)

bInArY
bInArY

Reputation: 1

Try replacing for ... in by for ... of

for(c of connectedClients) // ADDED
    c.sendUTF(message.utf8Data); // ADDED

Upvotes: 0

Vitalii Maslianok
Vitalii Maslianok

Reputation: 1631

I advise you to use Socket.IO: the cross-browser WebSocket for realtime apps. The module is very simple to install and configure

For example: Server

...
io.sockets.on('connection', function (socket) {
  //Sends the message or event to every connected user in the current namespace, except to your self.
  socket.broadcast.emit('Hi, a new user connected');

  //Sends the message or event to every connected user in the current namespace
  io.sockets.emit('Hi all');

  //Sends the message to one user
  socket.emit('news', {data:'data'});
  });
});
...

more

Client:

<script src="/socket.io/socket.io.js"></script>
<script>
  var socket = io.connect('http://localhost');
  //receive message
  socket.on('news', function (data) {
    console.log(data);
    //send message
    socket.emit('my other event', { my: 'data' });
  });
</script>

more about exposed events

Upvotes: 6

Related Questions