CODEWITHSUNDEEP
c#resharper
Esteban
Esteban

Reputation: 3127

How do I fix: Access to foreach variable in closure resharper warning?

I'm getting this ReSharper warning: Access to foreach variable in closure. May have different behaviour when compiled with different versions of compiler.

This is what I'm doing:

@foreach(var item in Model)
{
    // Warning underlines "item".
    <div>@Html.DisplayBooleanFor(modelItem => item.BooleanField)</div>
}

My extension is as follows:

public static MvcHtmlString DisplayBooleanFor<TModel, TValue>(
    this HtmlHelper<TModel> helper, 
    Expression<Func<TModel, TValue>> expression)
{
    bool value;

    try
    {
        var compiled = expression.Compile()(helper.ViewData.Model);
        value = Convert.ToBoolean(compiled);
    }
    catch (Exception)
    {
        value = false;
    }

    return MvcHtmlString.Create(value ? "Yes" : "No");
}

Note this is working as expected but how can I avoid this warning?
I'll appreciate any help provided.

Upvotes: 26

Views: 12736

Answers (2)

Ivan
Ivan

Reputation: 21

Another option is to apply JetBrains.Annotations.InstantHandleAttribute attribute to DisplayBooleanFor method.

Upvotes: 2

ChaosPandion
ChaosPandion

Reputation: 78312

A block scoped variable should resolve the warning.

@foreach(var item in Model)
{
    var myItem = item;
    <div>@Html.DisplayBooleanFor(modelItem => myItem.BooleanField)</div>
}

Upvotes: 25

Related Questions