CODEWITHSUNDEEP
cakephploopsforeach
Glenn Curtis
Glenn Curtis

Reputation: 659

Foreach logic issue with CakePHP

I have I problem that I hope someone can help me with. I thought this code was right, but it will not work. Below is my code, it is a function for my CakePHP 2.2.2 site, the main aim of the code is to produce a menu system from database results. The problem is with my foreach loop, it will not loop. All $Key does is return the value of 2 (three records within the table at this time). So When I display / echo / debug $Menu, the only result I get is the last result stored within the database.

I know the SQL command is right, if that is debuged / echoed then all three results are displayed. The idea of this loop was to get it to count the results, so that I could run a check on a selected field. Where I am going wrong?

function MenuSystem() {
 $this->loadModel('Menu');

 $MenuSQL = $this->Menu->find('all', array('conditions' => array('active' => true)));

 foreach ($MenuSQL as $Key=>$Value) {

    $MenuSystem = $MenuSQL[$Key];
    $this->Menu = $MenuSystem;

 }

 }

Many Thanks, Glenn.

UPDATE :::

Below is my function, now my foreach loop now works, don't know what I was doing wrong, but I know think its working. You can see the print_r command that I am using for testing, if I use that, then all links from my database are printed / echoed on the screen and all works. But if I try and call the $this->Menu from another controller, then only the last record is echoed on the screen. I have moved the $this->Menu outside of the foreach loop, but it made no difference, with it inside the loop or outside, it still only echoes the last record and not all three. So what I am doing wrong?

function MenuSystem() {
  $this->loadModel('Menu');
  $SiteBase = '/projects/cake/';
  $MenuSQL = $this->Menu->find('all', array('conditions' => array('active' => true)));

foreach ($MenuSQL as $key => $Value) {

    $MenuAccessLevel = $MenuSQL[$key]['Menu']['roles_id'];

    if ($MenuAccessLevel == 1) {
      $Path = $MenuSQL[$key]['Menu']['path'];
      $Title = $MenuSQL[$key]['Menu']['title'];
      $MenuSys = "<a href=\" " . $SiteBase . $Path . " \">" . $Title ."";
    } else {
       print ("Admin");
    }
    //print_r($MenuSys);
} //End of Foreach Loop 
   $this->Menu = $MenuSys;
} //End of function MenuSystem

Upvotes: 0

Views: 1766

Answers (1)

Ben Graham
Ben Graham

Reputation: 2099

So When I display / echo / debug $Menu, the only result I get is the last result stored within the database.

You're setting the value of $this->Menu within the foreach, so when the foreach is complete it will take the last value iterated over.

If you want to find the number of records matching a condition, try:

$menuCount = $this->Menu->find('count', array(
    'conditions'=>array('active'=>true)
));
$this->set(compact('menuCount'));

Edit: also, by setting the value of $this->Menu within the foreach, you're overwriting the Menu model variable. This is not a good idea.

Edit2: to get the counts of rows as grouped by some value, try:

$this->Menu->virtualFields = array('count' => 'count(*)');
$counts = $this->Menu->find('all', array(
    'group'=>'Role',
    'fields'=>array('Role', 'count'),
));

This generates SQL to have the results grouped by the Role column. Returned fields are the name of the role, and the number of rows having that value.

If you wanted to do it with a foreach loop instead, it might look like:

$menus = $this->Menu->find('all', array('fields'=>array('id', 'Role')));
$counts = array('user'=>0, 'admin'=>0);
foreach ($menus as $menu) {
    $role = $menu['Menu']['Role'];
    $counts[$role] += 1;
}

Upvotes: 3

Related Questions