CODEWITHSUNDEEP
c#.netgenerics.net-3.5static
kitsune
kitsune

Reputation: 11643

Generic classes with shared static fields in C#

I have a generic class definition similar to this:

public sealed class MyClass<TProperty,TOwner>
{
    ...
}

Now I'd like any instances of MyClass<TProperty,TOwner> regardless of the types of TProperty or TOwner to share a Hashtable. I thought of creating an internal MyClassBase with a protected internal static field of type Hashtable and inherit from that. I really only want the definition of MyClass to have access to this hashtable.

Is this a sound approach? I can't seal MyClassBase, so this probably could lead to opening a can of worms later on...

Are there other approaches for this?

Upvotes: 0

Views: 1528

Answers (2)

Sam Harwell
Sam Harwell

Reputation: 99889

Another option is to make an internal static class with an exposed member, and only access it from MyClass<T,U>. Sure, it'd be visible within your assembly, but that's easily controlled compared to a protected member. Just make sure to only use it in your MyClass<T,U> and it'll be fine.

Upvotes: 1

Rex M
Rex M

Reputation: 144122

The protected static Hashtable is a fine approach (make sure you synchronize it). You can't have an internal base class whose derived classes are public - but you can prevent it from being derived outside your assembly by making its default constructor internal:

public abstract class MyBaseClass
{
    internal MyBaseClass() { }

    private static Hashtable _hashtable;

    protected static Hashtable Hashtable
    {
        get
        {
            if(_hashtable == null)
            {
                _hashtable = Hashtable.Synchronized(new Hashtable());
            }
            return _hashtable;
        }
    }
}

Upvotes: 3

Related Questions