CODEWITHSUNDEEP
.netstream
Thomas Danecker
Thomas Danecker

Reputation: 4685

How to write the content of one stream into another stream in .net?

I often run into the problem that I have one stream full of data and want to write everything of it into another stream.

All code-examples out there use a buffer in form of a byte-array.

Is there a more elegant way to this?

If not, what's the ideal size of the buffer. Which factors make up this value?

Upvotes: 42

Views: 22335

Answers (7)

Ivan Koshelev
Ivan Koshelev

Reputation: 4260

As some people have suggested, CopyTo and CopyToAsync should do the job. Here is an example of a TCP server that listens for external connections on port 30303 and pipes them with local port 8085 (written in .NET 5). Most streams should work the same, just pay attention if they are bi-directional or single-direction.

using System.Net;
using System.Net.Sockets;
using System.Threading.Tasks;

namespace ConsoleApp1
{
    class Program
    {
        static async Task Main(string[] args)
        {
            var externalConnectionListener = new TcpListener(IPAddress.Any, 30303);
            externalConnectionListener.Start();

            while (true)
            {
                var externalConnection = await externalConnectionListener.AcceptTcpClientAsync().ConfigureAwait(false);

                _ = Task.Factory.StartNew(async () =>
                  {
                      using NetworkStream externalConnectionStream = externalConnection.GetStream();
                      using TcpClient internalConnection = new TcpClient("127.0.0.1", 8085);
                      using NetworkStream internalConnectionStream = internalConnection.GetStream();

                      await Task.WhenAny(
                                externalConnectionStream.CopyToAsync(internalConnectionStream),
                                internalConnectionStream.CopyToAsync(externalConnectionStream)).ConfigureAwait(false);

                  });

            }
        }
    }
}

Upvotes: 0

Thomas Danecker
Thomas Danecker

Reputation: 4685

In .NET 4.0 we finally got a Stream.CopyTo method! Yay!

Upvotes: 74

Leonid
Leonid

Reputation: 51

BufferedStream.CopyTo(Stream)

Upvotes: 5

KovBal
KovBal

Reputation: 2177

I'm not aware of a more elegant way, than using a buffer.

But the size of a buffer can make a difference. Remember the issues about Vista's File Copy? It's reason was (basically) changing the buffer size. The changes are explained in this blogpost. You can learn the main factors from that post. However, this only applies for file copying. In applications probably you do a lot of memory copies, so in that case, the 4KB could be the best buffer size, as recommended by the .NET documentation.

Upvotes: 2

Bill the Lizard
Bill the Lizard

Reputation: 405675

I'm not sure if you can directly pipe one stream to another in .NET, but here's a method to do it with an intermediate byte buffer. The size of the buffer is arbitrary. The most efficient size will depend mostly on how much data you're transferring.

static void CopyStream(Stream input, Stream output){
    byte[] buffer = new byte[0x1000];
    int read;
    while ((read = input.Read(buffer, 0, buffer.Length)) > 0) 
        output.Write(buffer, 0, read);
}

Upvotes: 8

tim_yates
tim_yates

Reputation: 171054

Read data in FileStream into a generic Stream

will probably have some directions to go in

Upvotes: 2

core
core

Reputation: 33059

Regarding the ideal buffer size:

"When using the Read method, it is more efficient to use a buffer that is the same size as the internal buffer of the stream, where the internal buffer is set to your desired block size, and to always read less than the block size. If the size of the internal buffer was unspecified when the stream was constructed, its default size is 4 kilobytes (4096 bytes)."

Any stream-reading process will use Read(char buffer[], int index, count), which is the method this quote refers to.

http://msdn.microsoft.com/en-us/library/9kstw824.aspx (Under "Remarks").

Upvotes: 16

Related Questions