CODEWITHSUNDEEP
javascriptjqueryscopenested
David Moreno García
David Moreno García

Reputation: 4523

Update global variable from jquery nested function

I have a problem with this piece of code:

var elements;
var current = 100;

$(document).ready(function() {
        elements =  = $('.slide').length;
        iterate();
});

function iterate() {
        $('.slide').eq(current).hide().queue(
                function() {
                        if (++current >= elements) { current = 0; }
                        $('.slide').eq(current).show();
                        $(this).dequeue();
                }
        );

        // Call this function again after the specified duration
        setTimeout(iterate, 1000);
}

What I'm trying to do is iterate all elements with 'slide' class but I have a problem updating 'current' variable. Its value is always 0. How can I modify a global variable from inside a nested jquery function?

Upvotes: 0

Views: 2542

Answers (1)

I Hate Lazy
I Hate Lazy

Reputation: 48761

If this line is invoked before the DOM is ready, .length is 0:

var elements = $('.slide').length;

Which means the condition for this if will always be true:

if (++current >= elements) { current = 0; }

You can fix it like this:

var elements;
var current = 100;

$(document).ready(function() {
    elements = $('.slide').length;
    iterate();
});

Also, this is a little bit of an odd use of .queue(). There's nothing that needs queueing.

I'd rework it like this:

function iterate() {
    var slide = $('.slide').eq(current).hide();
    if (++current >= elements) { current = 0; }
    $('.slide').eq(current).show();

    // Call this function again after the specified duration
    setTimeout(iterate, 1000);
}

Upvotes: 4

Related Questions