CODEWITHSUNDEEP
javascriptdatetimedate
Hellnar
Hellnar

Reputation: 64803

javascript date subtraction

I am looking for a way to do proper subtraction between two javascript Date objects and get the day delta.

This is my approach but it fails for todays date as an input:

<script type="text/javascript">
function getDayDelta(incomingYear,incomingMonth,incomingDay){
var incomingDate = new Date(incomingYear,incomingMonth,incomingDay);
var today = new Date();

var delta = incomingDate - today;
var resultDate = new Date(delta);
return resultDate.getDate();
}
//works for the future dates:
alert(getDayDelta(2009,9,10));
alert(getDayDelta(2009,8,19));

//fails for the today as input, as expected 0 delta,instead gives 31:
alert(getDayDelta(2009,8,18));
</script>

What would be a better approach for this ?

Upvotes: 7

Views: 22237

Answers (4)

Christian C. Salvad&#243;
Christian C. Salvad&#243;

Reputation: 827496

The month number in the Date constructor function is zero based, you should substract one, and I think that is simplier to calculate the delta using the timestamp:

function getDayDelta(incomingYear,incomingMonth,incomingDay){
  var incomingDate = new Date(incomingYear,incomingMonth-1,incomingDay),
      today = new Date(), delta;
  // EDIT: Set time portion of date to 0:00:00.000
  // to match time portion of 'incomingDate'
  today.setHours(0);
  today.setMinutes(0);
  today.setSeconds(0);
  today.setMilliseconds(0);

  // Remove the time offset of the current date
  today.setHours(0);
  today.setMinutes(0);

  delta = incomingDate - today;

  return Math.round(delta / 1000 / 60 / 60/ 24);
}


getDayDelta(2008,8,18); // -365
getDayDelta(2009,8,18); // 0
getDayDelta(2009,9,18); // 31

Upvotes: 7

John Fisher
John Fisher

Reputation: 22719

This will work better, but it doesn't properly deal with negative result values. You might want to simply parse the values yourself and deal with them.

function getDayDelta(incomingYear,incomingMonth,incomingDay){
var incomingDate = new Date(incomingYear,incomingMonth-1,incomingDay);
var today =   new Date();
today = new Date(Date.parse(today.format("yyyy/MM/dd")));

var delta = incomingDate - today;
if (delta == 0) { return 0; }
var resultDate = new Date(delta);
return resultDate.getDate();
}
//works for the future dates:
alert(getDayDelta(2009,9,10));
alert(getDayDelta(2009,8,19));
alert(getDayDelta(2009, 8, 18));

Upvotes: 0

Vijay Dev
Vijay Dev

Reputation: 27476

(2009,8,18) is NOT August 18th. It's September 18th.

Upvotes: 6

Robert J. Walker
Robert J. Walker

Reputation: 10355

You could call getTime() on each date object, then subtract the later from the earlier. This would give you the number of milliseconds difference between the two objects. From there, it's easy to get to days.

A couple of hiccups to watch for, though: 1) daylight savings time, and 2) ensuring your times are coming from the same time zone.

Upvotes: 5

Related Questions