CODEWITHSUNDEEP
phpvariable-assignmentconditional-operator
T9300X
T9300X

Reputation:

PHP Conditional Operator and Self Assignment

Is this sort of thing considered OK in PHP?

$foo = $_GET['foo'];
$foo = empty($foo) || !custom_is_valid($foo) ? 'default' : $foo;

Are there cleaner alternatives to this? I'm basically trying to avoid extra table look-ups.

Upvotes: 3

Views: 6458

Answers (5)

Peter Bailey
Peter Bailey

Reputation: 105878

A class here would make your life a lot easier.

<?php

class ParamHelper
{
  protected $source;

  public function __construct( array $source )
  {
    $this->source = $source;
  }

  public function get( $key, $default=null, $validationCallback=null )
  {
    if ( isset( $this->source[$key] ) && !empty( $this->source[$key] ) )
    {
      if ( is_null( $validationCallback ) || ( !is_null( $validationCallback ) && call_user_func( $validationCallback, $this->source[$key] ) ) )
      {
        return $this->source[$key];
      }
    }
    return $default;
  }
}

// Just for the demo
function validateUpper( $value )
{
  return ( $value == strtoupper( $value ) );
}

// Mimic some query-string values
$_GET['foo'] = 'bar';
$_GET['bar'] = 'BAZ';
$_GET['lol'] = 'el oh el';

$getHelper = new ParamHelper( $_GET );

echo $getHelper->get( 'foo', 'foo default', 'validateUpper' ), '<br>';
echo $getHelper->get( 'bar', 'bar default', 'validateUpper' ), '<br>';
echo $getHelper->get( 'baz', 'baz default' ), '<br>';
echo $getHelper->get( 'lol' ), '<br>';
echo $getHelper->get( 'rofl' ), '<br>';

Upvotes: 0

anveo
anveo

Reputation: 345

Perhaps instead of just checking if it is valid, run it though a cleaning function that takes a default.

Also, I like to use the following function so I don't get warnings on accessing non-existant array keys when running E_STRICT:

function GetVar($var, $default = '') {
  $value = $default;
  if(isset($_GET[$var])) {
    $value = $_GET[$var];
  }
  return $value;
}

function custom_clean($value, $default = '') {
  ... validation logic or return $default ...
}

$foo = custom_clean(GetVar('foo'), 'default');

Upvotes: 0

Anti Veeranna
Anti Veeranna

Reputation: 11583

How about:

$foo = 'default';
if (array_key_exists('foo', $_GET) and custom_is_valid($_GET['foo'])) {
    $foo = $_GET['foo'];
}

And don't be afraid of the array lookups, they are not that slow :)

Upvotes: 0

chaos
chaos

Reputation: 124297

As you'll see if you turn error_reporting(E_ALL) on, that isn't really the best way to do it. PHP basically wants you to do

$foo = empty($_GET['foo']) || !custom_is_valid($_GET['foo']) ? 'default' : $_GET['foo'];

Upvotes: 2

MattBelanger
MattBelanger

Reputation: 5350

Does custom_is_valid() check for an empty variable? Because being able to remove the empty() and "or not" would go a long way to improving that code.

Upvotes: 3

Related Questions