CODEWITHSUNDEEP
rubyjson
Anthony
Anthony

Reputation: 342

Ruby json parse error: unexpected token

I have a working method that opens and parses a json file. Now I'm trying to iterate through a directory of json files and display their contents.

Working method for a single file:

def aperson
  File.open("people/Elvis Presley.json") do |f|
    parse = JSON.parse(f.read) 
  end
end

Non-working method to iterate through a directory:

16. def list
17.   Dir.glob('people/*').each do |f|
18.     parse = JSON.parse(f) 
19    end
20. end

My error is:

/Users/ad/.rbenv/versions/1.9.3-p194/lib/ruby/1.9.1/json/common.rb:148:in `parse': 743: unexpected token at 'people/Elvis Presley.json' (JSON::ParserError)
    from /Users/ad/.rbenv/versions/1.9.3-p194/lib/ruby/1.9.1/json/common.rb:148:in `parse'
    from app.rb:18:in `block in list'
    from app.rb:17:in `each'
    from app.rb:17:in `list'
    from app.rb:24:in `<main>'

All of the files in the directory have the same content and are valis as per JSONlint.

Any help would be greatly appreciated.

Upvotes: 4

Views: 4105

Answers (3)

HungryCoder
HungryCoder

Reputation: 7616

In your non-working code, f is just string of the expanded file name. So you need to read the file after you've received the filename in the block.

While writing it, @nneonneo already gave you solution. So I'm not giving again.

Upvotes: 1

nneonneo
nneonneo

Reputation: 179412

You tried to parse the filename as JSON, which won't work.

Instead, you need to read the file first:

parse = JSON.parse(File.read(f))

Upvotes: 9

user904990
user904990

Reputation:

not sure, but can you try to parse the content of file instead of file name:

parse = JSON.parse( File.read f )

Upvotes: 4

Related Questions