CODEWITHSUNDEEP
c#.netdesign-patterns
Life is more than this
Life is more than this

Reputation: 267

Which design pattern should I use?

I have the following code which executes in sequence, method after another.

I load the request, perform a couple of checks like checking if a response already exists for this request, if not, I call the service and receive the response which I save to the DB.

I was looking for a design pattern I can use in such a case, I thought of posting this here and get some ideas.

public class Manager
    {

        public void PutRequest()
        {
            //Do Something

            if (loadRequest())
            {
                  callService(); 

                  //Do Something
                  saveResponse();
            }

        }

        private bool loadRequest()
        {            
             bool isExist = checkIfResponseExists();

             if (!isExist)
             {
              // If false, load request from DB
             } 

             return !isExist;

        }

        private bool checkIfDataExists()
        {
            //Check if a response already exists in the DB for this request
        }

        private void callService()
        {
            //Call the service and receive the response
        }    

        private void saveResponse()
        {
            //Store the response in the DB
        }

    }

Upvotes: 0

Views: 228

Answers (5)

Prasanth V J
Prasanth V J

Reputation: 1196

While selecting a pattern you should consider scalability of the application

One of the pattern you can apply is state pattern

There will be two states.

  1. Response is already there
  2. Need to process the new response

Upvotes: 0

Anders Johansen
Anders Johansen

Reputation: 10475

Command + Composite.

Some people consider the use of an if/then Command - in your case that would be in putRequest - in a Composite a kind of Chain Of Responsibility.

Upvotes: 0

Sergey Berezovskiy
Sergey Berezovskiy

Reputation: 236308

Patterns are used for solving some problems. What problem your current code have? I don't see any duplicated code, beside names of methods. There is no pattern, which fixes method naming problem.

Yes, your code need some refactoring, but not to patterns. Better class and method naming is a first step. Also, I'd removed field isExist.

public class Manager
{
   public void PutRequest()
   {
       //Do Something
       if (!CheckIfResponseExists()) // returns boolean value
            LoadRequestFromDB()

        CallService(); 
        //Do Something
        SaveResponse();
   }
}

Upvotes: 1

Jeff B
Jeff B

Reputation: 9002

It seems like it'd be more useful for several of these methods to be functions. So instead of having a method who's responsibility is to both check for a condition and do some other actions, you have a function that checks for a condition then the method that called it does some action depending on the result. (Kind of the SRP applied to methods...)

public void DoAllTheThings!() // Oops, Ruby syntax creeping in :P
{
   if(!WeCanDoIt())
   {
     MakeItSo(); // So that we can do it...
   }

   NowWeCanDoAllTheThings();
}

private bool WeCanDoIt() {}
private void MakeItSo() {}
private void NowWeCanDoAllTheThings() {}

Upvotes: 0

Allan Ramírez
Allan Ramírez

Reputation: 2709

Check the design pattern called Strategy, it defines an interface common to all supported algorithms and each concrete strategy implements an algorithm

http://www.oodesign.com/strategy-pattern.html

Upvotes: 0

Related Questions